Ticket #10541: 10541-v2.patch

mythtv/libs/libmythtv/eitscanner.cpp

@@ -75 +75 @@
     static const float rt[] = { 0.0f, 0.2f, 0.4f, 0.6f, 0.8f, };
 
     lock.lock();
-    exitThread = false;
 
     MythTimer t;
     uint eitCount = 0;
@@ -149 +148 @@
         }
 
         lock.lock();
-        if (!exitThread)
+        if ((activeScan || activeScanStopped) && !exitThread)
             exitThreadCond.wait(&lock, 400); // sleep up to 400 ms.
+
+        if (!activeScan && !activeScanStopped)
+        {
+            activeScanStopped = true;
+            activeScanCond.wakeAll();
+        }
     }
+    activeScanStopped = true;
+    activeScanCond.wakeAll();
     lock.unlock();
 }
 
@@ -271 +278 @@
         // Add a little randomness to trigger time so multiple
         // cards will have a staggered channel changing time.
         activeScanTrigTime += random() % 29;
+        activeScanStopped = false;
         activeScan = true;
     }
 }
 
-void EITScanner::StopActiveScan()
+void EITScanner::StopActiveScan(void)
 {
+    QMutexLocker locker(&lock);
+
+    activeScanStopped = false;
     activeScan = false;
-    rec = NULL;
+    exitThreadCond.wakeAll();
+
+    locker.unlock();
     StopPassiveScan();
+    locker.relock();
+
+    while (!activeScan && !activeScanStopped)
+        activeScanCond.wait(&lock, 100);
+
+    rec = NULL;
 }

mythtv/libs/libmythtv/eitscanner.h

@@ -54 +54 @@
 
     EITHelper       *eitHelper;
     MThread         *eventThread;
-    bool             exitThread;
-    QWaitCondition   exitThreadCond;
+    volatile bool    exitThread;
+    QWaitCondition   exitThreadCond; // protected by lock
 
     TVRec           *rec;
-    bool             activeScan;
+    volatile bool    activeScan;
+    volatile bool    activeScanStopped; // protected by lock
+    QWaitCondition   activeScanCond; // protected by lock
     QDateTime        activeScanNextTrig;
     uint             activeScanTrigTime;
     QStringList      activeScanChannels;