Ticket #2080: freebox-xmltvid.diff

libs/libmythtv/freeboxchannelinfo.h

@@ -7 +7 @@
 class FreeboxChannelInfo
 {
   public:
-    FreeboxChannelInfo() : m_name(QString::null), m_url(QString::null) {}
+    FreeboxChannelInfo() :
+        m_name(QString::null),
+        m_url(QString::null),
+        m_xmltvid(QString::null) {}
 
-    FreeboxChannelInfo(const QString &name, const QString &url) :
-        m_name(name), m_url(url) {}
+    FreeboxChannelInfo(const QString &name,
+                       const QString &url,
+                       const QString &xmltvid) :
+        m_name(name), m_url(url), m_xmltvid(xmltvid) {}
 
     bool isValid(void) const
     {
@@ -20 +25 @@
   public:
     QString m_name;
     QString m_url;
+    QString m_xmltvid;
 };
 
 typedef QMap<QString,FreeboxChannelInfo> fbox_chan_map_t;

libs/libmythtv/freeboxchannelfetcher.cpp

@@ -14 +14 @@
 #define LOC QString("FBChanFetch: ")
 #define LOC_ERR QString("FBChanFetch, Error: ")
 
-static bool parse_chan_info(
-    const QString &line1, QString &channum, QString &name);
+static bool parse_chan_info(const QString      &rawdata,
+                            FreeboxChannelInfo &info,
+                            QString            &channum,
+                            uint               &lineNum);
+static bool parse_extinf(const QString &data,
+                         QString &channum, QString &name);
 
 FreeboxChannelFetcher::FreeboxChannelFetcher(unsigned _sourceid,
                                              unsigned _cardid) :
@@ -119 +123 @@
     {
         QString channum = it.key();
         QString name    = (*it).m_name;
+        QString xmltvid = (*it).m_xmltvid.isEmpty() ? "" : (*it).m_xmltvid;
         QString msg     = tr("Channel #%1 : %2").arg(channum).arg(name);
 
         int chanid = ChannelUtil::GetChanID(sourceid, channum);
@@ -128 +133 @@
             chanid = ChannelUtil::CreateChanID(sourceid, channum);
             ChannelUtil::CreateChannel(
                 0, sourceid, chanid, name, name, channum,
-                0, 0, 0, false, false, false, 0);
+                0, 0, 0, false, false, false, 0,
+                "", "Default", xmltvid);
         }
         else
         {
             emit ServiceScanUpdateText(tr("Updating %1").arg(msg));
             ChannelUtil::UpdateChannel(
                 0, sourceid, chanid, name, name, channum, 0, 0, 0, 0);
+            //TODO Update the xmltvid
         }
 
         SetNumChannelsInserted(i);
@@ -187 +194 @@
     return QString::fromUtf8(tmp);
 }
 
+static uint EstimateNbChannels(const QString &rawdata)
+{
+    uint result = 0;
+    uint numLine = 1;
+    while (true)
+    {
+        QString url = rawdata.section("\n", numLine, numLine);
+        if (url.isEmpty())
+            return result;
+
+        ++numLine;
+        if (!url.startsWith("#")) // ignore comments
+            ++result;
+    }
+}
+
 fbox_chan_map_t FreeboxChannelFetcher::ParsePlaylist(
     const QString &rawdata, FreeboxChannelFetcher *fetcher)
 {
@@ -206 +229 @@
     }
 
     // estimate number of channels
-    for (uint i = 1; fetcher; i += 2)
+    if (fetcher)
     {
-        QString url = rawdata.section("\n", i+1, i+1);
-        if (url.isEmpty())
-        {
-            fetcher->SetTotalNumChannels(i>>1);
-
-            VERBOSE(VB_CHANNEL, "Estimating there are "<<(i>>1)
-                    <<" channels in playlist");
-
-            break;
-        }
+        uint nbChannels = EstimateNbChannels(rawdata);
+        VERBOSE(VB_CHANNEL, "Estimating there are "<<nbChannels
+                <<" channels in playlist");
+        fetcher->SetTotalNumChannels(nbChannels);
     }
 
     // Parse each channel
-    for (int i = 1; true; i += 2)
+    uint lineNum = 1;
+    uint nbParsed = 0;
+    QString channum;
+    FreeboxChannelInfo info;
+    while (parse_chan_info(rawdata, info, channum, lineNum))
     {
-        QString tmp = rawdata.section("\n", i+0, i+0);
-        QString url = rawdata.section("\n", i+1, i+1);
-        if (tmp.isEmpty() || url.isEmpty())
-            break;
-
-        QString channum, name;
+        ++nbParsed;
         QString msg = tr("Encountered malformed channel");
-        if (parse_chan_info(tmp, channum, name))
+        if (!channum.isEmpty())
         {
-            chanmap[channum] = FreeboxChannelInfo(name, url);
-
+            chanmap[channum] = info;
             msg = tr("Parsing Channel #%1 : %2 : %3")
-                .arg(channum).arg(name).arg(url);
-
+                .arg(channum).arg(info.m_name).arg(info.m_url);
             VERBOSE(VB_CHANNEL, msg);
-
             msg = QString::null; // don't tell fetcher
         }
 
@@ -246 +259 @@
         {
             if (!msg.isEmpty())
                 fetcher->SetMessage(msg);
-            fetcher->SetNumChannelsParsed(1+(i>>1));
+            fetcher->SetNumChannelsParsed(nbParsed);
         }
     }
 
     return chanmap;
 }
 
-static bool parse_chan_info(const QString &line1,
-                            QString &channum, QString &name)
+static bool parse_chan_info(const QString      &rawdata,
+                            FreeboxChannelInfo &info,
+                            QString            &channum,
+                            uint               &lineNum)
 {
-    // each line contains ://
-    // header:extension,channelNum - channelName rtsp://channelUrl
-    //#EXTINF:0,2 - France 2 rtsp://mafreebox.freebox.fr/freeboxtv/201
+    // #EXTINF:0,2 - France 2                <-- duration,channum - channame
+    // #EXTMYTHTV:xmltvid=C2.telepoche.com   <-- optional line (myth specific)
+    // #...                                  <-- ignored comments
+    // rtsp://mafreebox.freebox.fr/freeboxtv/201 <-- url
 
-    QString msg = LOC_ERR +
-        QString("Invalid header in channel list line \n\t\t\t%1").arg(line1);
+    QString name;
+    QString xmltvid;
+    while (true)
+    {
+        QString line = rawdata.section("\n", lineNum, lineNum);
+        if (line.isEmpty())
+            return false;
 
-    channum = name = QString::null;
-
-    // Verify Line Header
-    int pos = line1.find(":", 0);
-    if ((pos < 0) || (line1.mid(0, pos) != "#EXTINF"))
-    {
-        VERBOSE(VB_IMPORTANT, msg);
-        return false;
+        ++lineNum;
+        if (line.startsWith("#"))
+        {
+            if (line.startsWith("#EXTINF:"))
+            {
+                parse_extinf(line.mid(line.find(':')+1), channum, name);
+            }
+            else if (line.startsWith("#EXTMYTHTV:"))
+            {
+                QString data = line.mid(line.find(':')+1);
+                if (data.startsWith("xmltvid="))
+                {
+                    xmltvid = data.mid(data.find('=')+1);
+                }
+            }
+            else
+            {
+                // Just ignore other comments
+            }
+        }
+        else
+        {
+            if (name.isEmpty())
+                return false;
+            QString url = line;
+            info = FreeboxChannelInfo(name, url, xmltvid);
+            return true;
+        }
     }
+}
 
+static bool parse_extinf(const QString &line1,
+                         QString &channum, QString &name)
+{
+    // data is supposed to contain the "0,2 - France 2" part
+    QString msg = LOC_ERR +
+        QString("Invalid header in channel list line \n\t\t\tEXTINF:%1")
+        .arg(line1);
+
     // Parse extension portion
-    pos = line1.find(",", pos + 1);
+    int pos = line1.find(",");
     if (pos < 0)
     {
         VERBOSE(VB_IMPORTANT, msg);
         return false;
     }
-    //list.push_back(line1.mid(oldPos, pos - oldPos));
 
     // Parse freebox channel number
     int oldpos = pos + 1;

libs/libmythtv/rtspcomms.cpp

@@ -395 +395 @@
     while ((subsession = mit.next())) /* <- extra braces for pedantic gcc */
     {
         FreeboxMediaSink *sink = NULL;
-        if (sink = dynamic_cast<FreeboxMediaSink*>(subsession->sink))
+        if ((sink = dynamic_cast<FreeboxMediaSink*>(subsession->sink)))
             sink->AddListener(item);
     }
     VERBOSE(VB_RECORD, LOC + "AddListener("<<item<<") -- end 2");
@@ -430 +430 @@
     while ((subsession = mit.next())) /* <- extra braces for pedantic gcc */
     {
         FreeboxMediaSink *sink = NULL;
-        if (sink = dynamic_cast<FreeboxMediaSink*>(subsession->sink))
+        if ((sink = dynamic_cast<FreeboxMediaSink*>(subsession->sink)))
             sink->RemoveListener(item);
     }
     VERBOSE(VB_RECORD, LOC + "RemoveListener("<<item<<") -- end 3");