Ticket #2544: mythtv-cleanup_program_listings_through_housekeeper-after_rec_rules.patch

programs/mythbackend/housekeeper.h

@@ -19 +19 @@
 
     
   protected:
+    typedef struct mfdstruct
+    {
+        HouseKeeper *keep;
+        QString mfpath;
+        QString mfarg;
+        QString mflog;
+    } MFDStruct;
+
     void RunHouseKeeping(void);
     static void *doHouseKeepingThread(void *param);
 
-    void RunMFD(void);
+    void RunMFD(const MFDStruct *mfds);
     static void *runMFDThread(void *param);
 
   private:
@@ -31 +39 @@
     void updateLastrun(const QString &dbTag);
     QDateTime getLastRun(const QString &dbTag);
     void flushLogs();
-    void runFillDatabase();
+    void runFillDatabase(MFDStruct *mfds);
     void CleanupMyOldRecordings(void);
     void CleanupAllOldInUsePrograms(void);
     void CleanupRecordedTables(void);
     void CleanupExpiredRecordingRules(void);
     void CleanupOldrecordedTable(void);
+    void CleanupProgramListings(void);
     bool threadrunning;
     bool filldbRunning;
     bool isMaster;

programs/mythbackend/housekeeper.cpp

@@ -215 +215 @@
                         QString msg = "Running mythfilldatabase";
                         gContext->LogEntry("mythbackend", LP_DEBUG, msg, "");
                         VERBOSE(VB_GENERAL, msg);
-                        runFillDatabase();
+
+                        MFDStruct *mfds = new MFDStruct;
+
+                        mfds->mfpath = gContext->GetSetting(
+                                             "MythFillDatabasePath",
+                                             "mythfilldatabase");
+                        mfds->mfarg  = gContext->GetSetting(
+                                             "MythFillDatabaseArgs", "");
+                        mfds->mflog  = gContext->GetSetting(
+                                             "MythFillDatabaseLog",
+                                             "/var/log/mythfilldatabase.log");
+
+                        runFillDatabase(mfds);
                         updateLastrun("MythFillDB");
                     }
                 }
@@ -225 +237 @@
                 JobQueue::CleanupOldJobsInQueue();
                 CleanupAllOldInUsePrograms();
                 CleanupRecordedTables();
                 CleanupExpiredRecordingRules();
                 CleanupOldrecordedTable();
+                CleanupProgramListings();
                 updateLastrun("DailyCleanup");
             }
         }
@@ -266 +279 @@
 
 void *HouseKeeper::runMFDThread(void *param)
 {
-    HouseKeeper *keep = (HouseKeeper *)param;
-    keep->RunMFD();
+    MFDStruct *mfds = (MFDStruct *)param;
+
+    HouseKeeper *keep = mfds->keep;
+    keep->RunMFD(mfds);
+
+    delete mfds;
+
     return NULL;
 }
 
-void HouseKeeper::RunMFD(void)
+void HouseKeeper::RunMFD(const MFDStruct *mfds)
 {
     QString command;
 
-    QString mfpath = gContext->GetSetting("MythFillDatabasePath",
-                                          "mythfilldatabase");
-    QString mfarg = gContext->GetSetting("MythFillDatabaseArgs", "");
-    QString mflog = gContext->GetSetting("MythFillDatabaseLog",
-                                         "/var/log/mythfilldatabase.log");
+    QString mfpath = mfds->mfpath;
+    if (mfpath == "mythfilldatabase")
+        mfpath = gContext->GetInstallPrefix() + "/bin/mythfilldatabase";
 
+    QString mfarg = mfds->mfarg;
+    QString mflog = mfds->mflog;
+
     if (mflog == "")
         command = QString("%1 %2").arg(mfpath).arg(mfarg);
     else
@@ -292 +311 @@
     HouseKeeper_filldb_running = false;
 }
 
-void HouseKeeper::runFillDatabase()
+void HouseKeeper::runFillDatabase(MFDStruct *mfds)
 {
     if (HouseKeeper_filldb_running)
         return;
@@ -300 +319 @@
     HouseKeeper_filldb_running = true;
 
     pthread_t housekeep_thread;
-    pthread_create(&housekeep_thread, NULL, runMFDThread, this);
+    pthread_create(&housekeep_thread, NULL, runMFDThread, mfds);
     pthread_detach(housekeep_thread);
 }
 
@@ -368 +387 @@
     query.exec();
 }
 
+void HouseKeeper::CleanupProgramListings(void)
+{
+    if (!gContext->GetNumSetting("MythFillEnabled", 0))
+    {
+        MFDStruct *mfds = new MFDStruct;
+
+        mfds->mfpath = "mythfilldatabase";
+        mfds->mfarg  = "--do-cleanup-only --no-delete";
+        mfds->mflog  = gContext->GetSetting("MythFillDatabaseLog",
+                                            "/var/log/mythfilldatabase.log");
+
+        runFillDatabase(mfds);
+    }
+}
+
 void *HouseKeeper::doHouseKeepingThread(void *param)
 {
     HouseKeeper *hkeeper = (HouseKeeper*)param;

programs/mythfilldatabase/filldata.cpp

@@ -62 +62 @@
 bool dd_grab_all = false;
 bool dddataretrieved = false;
 bool mark_repeats = true;
+bool do_cleanup_only = false;
 bool channel_updates = false;
 bool channel_update_run = false;
 bool remove_new_channels = false;
@@ -3591 +3592 @@
         {
              mark_repeats = false;
         }
+        else if (!strcmp(a.argv()[argpos], "--do-cleanup-only"))
+        {
+            do_cleanup_only = true;
+            grab_data = false;
+            mark_repeats = false;
+        }
         else if (!strcmp(a.argv()[argpos], "--export-icon-map"))
         {
             export_iconmap = true;
@@ -3746 +3753 @@
             cout << "--reset-icon-map [all]\n";
             cout << "   Resets your icon map (pass all to reset channel icons as well)\n";
             cout << "\n";
+#if 0
+            cout << "--do-cleanup-only\n";
+            cout << "   Cleans old program listings from the database.\n";
+            cout << "\n";
+#endif
             cout << "--mark-repeats\n";
             cout << "   Marks any programs with a OriginalAirDate earlier\n";
             cout << "   than their start date as a repeat\n";
@@ -3987 +3999 @@
                 QString("    Found %1").arg(query.numRowsAffected()));
     }
 
+    if (do_cleanup_only)
+    {
+        clearOldDBEntries();
+    }
+
     if (mark_repeats)
     {
         VERBOSE(VB_GENERAL, "Marking repeats.");

programs/mythfrontend/globalsettings.cpp

@@ -2919 +2919 @@
 static GlobalLineEdit *MythFillDatabasePath()
 {
     GlobalLineEdit *be = new GlobalLineEdit("MythFillDatabasePath");
-    be->setLabel(QObject::tr("mythfilldatabase Path"));
-    be->setValue(gContext->GetInstallPrefix() + "/bin/mythfilldatabase");
-    be->setHelpText(QObject::tr("Path (including executable) of the "
-                    "mythfilldatabase program."));
+    be->setLabel(QObject::tr("mythfilldatabase Program"));
+    be->setValue("mythfilldatabase");
+    be->setHelpText(QObject::tr("Use 'mythfilldatabase' or the name of a "
+                    "custom script that will populate the program guide info "
+                    "for you."));
     return be;
 }