Ticket #3353: mythtv_remotepreviewgen.2.patch

libs/libmythtv/previewgenerator.h

@@ -24 +24 @@
 
     Q_OBJECT
   public:
-    PreviewGenerator(const ProgramInfo *pginfo, bool local_only = true);
+    typedef enum {
+        kNone = 0,
+        kLocal = 1,
+        kRemote = 2,
+        kLocalAndRemote = 3,
+        kModeMask = 3
+    } Mode;
 
+  public:
+    PreviewGenerator(const ProgramInfo *pginfo, Mode mode = kLocal);
+
     void SetPreviewTime(long long time, bool in_seconds)
         { captureTime = time; timeInSeconds = in_seconds; }
     void SetPreviewTimeAsSeconds(long long seconds_in)
@@ -87 +96 @@
     pthread_t          previewThread;
     ProgramInfo        programInfo;
 
-    bool               localOnly;
+    Mode               mode;
     bool               isConnected;
     bool               createSockets;
     MythSocket        *serverSock;

libs/libmythtv/previewgenerator.cpp

@@ -64 +64 @@
  *                    if the file is local.
  */
 PreviewGenerator::PreviewGenerator(const ProgramInfo *pginfo,
-                                   bool local_only)
-    : programInfo(*pginfo), localOnly(local_only), isConnected(false),
+                                   PreviewGenerator::Mode _mode)
+    : programInfo(*pginfo), mode(_mode), isConnected(false),
       createSockets(false), serverSock(NULL),      pathname(pginfo->pathname),
       timeInSeconds(true),  captureTime(-1),       outFileName(QString::null),
       outSize(0,0)
 {
-    if (IsLocal())
+    if (IsLocal() && !(mode & kRemote))
         return;
 
     // Try to find a local means to access file...
@@ -167 +167 @@
 {
     bool ok = false;
     bool is_local = IsLocal();
-    if (is_local && LocalPreviewRun())
+    if (is_local && (mode && kLocal) && LocalPreviewRun())
     {
         ok = true;
     }
-    else if (!localOnly)
+    else if (mode & kRemote)
     {
         if (is_local)
         {
@@ -194 +194 @@
 bool PreviewGenerator::Run(void)
 {
     bool ok = false;
-    if (!IsLocal())
+    bool local_ok = IsLocal() && (mode & kLocal);
+    if (!local_ok)
     {
-        if (!localOnly)
+        if (mode & kRemote)
         {
             ok = RemotePreviewRun();
         }

libs/libmythtv/jobqueue.cpp

@@ -2178 +2178 @@
         gContext->dispatch(me);
 
         program_info->pathname = program_info->GetPlaybackURL();
-        (new PreviewGenerator(program_info, true))->Run();
+        (new PreviewGenerator(program_info, PreviewGenerator::kLocal))->Run();
     }
 
     msg = QString("Commercial Flagging %1")

libs/libmythtv/tv_play.cpp

@@ -8173 +8173 @@
         .arg(playbackinfo->recstartts.toString("yyyyMMddhhmmss"))
         .arg((long)frameNumber);
 
-    PreviewGenerator *previewgen = new PreviewGenerator(playbackinfo, false);
+    PreviewGenerator *previewgen = new PreviewGenerator(playbackinfo, PreviewGenerator::kLocalAndRemote);
     pbinfoLock.unlock();
 
     previewgen->SetPreviewTimeAsFrameNumber(frameNumber);

libs/libmythtv/tv_rec.cpp

@@ -1108 +1108 @@
     {
         if (!killFile)
         {
-            (new PreviewGenerator(curRecording, true))->Start();
+            (new PreviewGenerator(curRecording, PreviewGenerator::kLocal))->Start();
 
             if (!tvchain)
             {
@@ -4383 +4383 @@
     if (oldinfo)
     {
         FinishedRecording(oldinfo);
-        (new PreviewGenerator(oldinfo, true))->Start();
+        (new PreviewGenerator(oldinfo, PreviewGenerator::kLocal))->Start();
         delete oldinfo;
     }
 

programs/mythfrontend/playbackbox.cpp

@@ -304 +304 @@
         previewVideoEnabled =gContext->GetNumSetting("PlaybackPreview");
     previewPixmapEnabled=gContext->GetNumSetting("GeneratePreviewPixmaps");
     previewFromBookmark= gContext->GetNumSetting("PreviewFromBookmark");
+    previewGeneratorMode= gContext->GetNumSetting("GeneratePreviewRemotely", 0)?PreviewGenerator::kRemote:PreviewGenerator::kLocalAndRemote;
     drawTransPixmap    = gContext->LoadScalePixmap("trans-backup.png");
     if (!drawTransPixmap)
         drawTransPixmap = new QPixmap();
@@ -4675 +4676 @@
         uint attempts = IncPreviewGeneratorAttempts(filename);
         if (attempts < PreviewGenState::maxAttempts)
         {
-            SetPreviewGenerator(filename, new PreviewGenerator(pginfo, false));
+            SetPreviewGenerator(filename, new PreviewGenerator(pginfo, (PreviewGenerator::Mode)previewGeneratorMode));
         }
         else if (attempts == PreviewGenState::maxAttempts)
         {
@@ -4742 +4743 @@
         if (attempts < PreviewGenState::maxAttempts)
         {
             VERBOSE(VB_PLAYBACK, "Starting preview generator");
-            SetPreviewGenerator(filename, new PreviewGenerator(pginfo, false));
+            SetPreviewGenerator(filename, new PreviewGenerator(pginfo, (PreviewGenerator::Mode)previewGeneratorMode));
         }
         else if (attempts == PreviewGenState::maxAttempts)
         {

programs/mythfrontend/globalsettings.cpp

@@ -2014 +2046 @@
     return gc;
 }
 
+static HostCheckBox *GeneratePreviewRemotely()
+{
+    HostCheckBox *gc = new HostCheckBox("GeneratePreviewRemotely");
+    gc->setLabel(QObject::tr("Generate preview image remotely"));
+    gc->setValue(false);
+    gc->setHelpText(QObject::tr("If enabled, the static image of the recording will "
+                    "NOT be generated on the local machine."));
+    return gc;
+}
+
 static HostCheckBox *PlayBoxTransparency()
 {
     HostCheckBox *gc = new HostCheckBox("PlayBoxTransparency");
@@ -4510 +4558 @@
     pbox->addChild(PlayBoxOrdering());
     pbox->addChild(PlayBoxEpisodeSort());
     pbox->addChild(GeneratePreviewPixmaps());
+    pbox->addChild(GeneratePreviewRemotely());
     pbox->addChild(PreviewPixmapOffset());
     pbox->addChild(PreviewFromBookmark());
     pbox->addChild(PlaybackPreview());

programs/mythbackend/main.cpp

@@ -319 +319 @@
         return GENERIC_EXIT_NOT_OK;
     }
 
-    PreviewGenerator *previewgen = new PreviewGenerator(pginfo, true);
+    PreviewGenerator *previewgen = new PreviewGenerator(pginfo, PreviewGenerator::kLocal);
 
     if (previewFrameNumber >= 0)
         previewgen->SetPreviewTimeAsFrameNumber(previewFrameNumber);

programs/mythbackend/mythxml.cpp

@@ -1067 +1067 @@
         // Must generate Preview Image, Generate Image and save.
         // ------------------------------------------------------------------
 
-        PreviewGenerator *previewgen = new PreviewGenerator(pInfo, true);
+        PreviewGenerator *previewgen = new PreviewGenerator(pInfo, PreviewGenerator::kLocal);
         previewgen->SetPreviewTimeAsSeconds(nSecsIn);
         previewgen->SetOutputFilename(sFileName + ".png");
         bool ok = previewgen->Run();