Ticket #7014: libs_libmythui-use-after-free

File libs_libmythui-use-after-free, 715 bytes (added by Erik Hovland <erik@…>, 16 years ago)

zero both sha_bang and filename after free

Line 
1Make sure memory is not used after it is freed.
2
3From: Erik Hovland <erik@hovland.org>
4
5
6---
7
8 mythtv/libs/libmythui/lirc_client.c | 4 ++--
9 1 files changed, 2 insertions(+), 2 deletions(-)
10
11
12diff --git a/mythtv/libs/libmythui/lirc_client.c b/mythtv/libs/libmythui/lirc_client.c
13index c11f2fc..e826770 100644
14--- a/mythtv/libs/libmythui/lirc_client.c
15+++ b/mythtv/libs/libmythui/lirc_client.c
16@@ -932,8 +932,8 @@ int lirc_readconfig(const struct lirc_state *state,
17 goto lirc_readconfig_compat;
18 }
19
20- if(sha_bang!=NULL) free(sha_bang);
21- free(filename);
22+ if(sha_bang!=NULL) { free(sha_bang); sha_bang = NULL; }
23+ free(filename); filename = NULL;
24
25 sockfd=socket(AF_UNIX,SOCK_STREAM,0);
26 if(sockfd==-1)