Ticket #9511: 103-livetv_buffer_underrun_v2.patch

libs/libmythtv/fileringbuffer.cpp

@@ -349 +349 @@
         }
     }
 
-    setswitchtonext = false;
     ateof = false;
     commserror = false;
     numfailures = 0;

libs/libmythtv/mythplayer.cpp

@@ -2271 +2271 @@
 
     bool newIsDummy = player_ctx->tvchain->GetCardType(newid) == "DUMMY";
 
+    if (!newIsDummy)
+    {
+        player_ctx->buffer->OpenFile(
+            pginfo->GetPlaybackURL(), RingBuffer::kDefaultOpenTimeout);
+    }
     SetPlayingInfo(*pginfo);
     Pause();
     ChangeSpeed();
@@ -2284 +2289 @@
         return;
     }
 
-    player_ctx->buffer->OpenFile(
-        pginfo->GetPlaybackURL(), RingBuffer::kDefaultOpenTimeout);
-
     if (!player_ctx->buffer->IsOpen())
     {
         VERBOSE(VB_IMPORTANT, LOC_ERR + "SwitchToProgram's OpenFile failed " +

libs/libmythtv/ringbuffer.cpp

@@ -450 +450 @@
     internalreadpos = newinternal;
     ateof = false;
     readsallowed = false;
-    setswitchtonext = false;
     generalWait.wakeAll();
 
     rbwlock.unlock();
@@ -698 +697 @@
 
         // These are conditions where we want to sleep to allow
         // other threads to do stuff.
-        if (setswitchtonext || (ateof && readsallowed))
+        if (ateof && readsallowed)
         {
             ignore_for_read_timing = true;
             generalWait.wait(&rwlock, 1000);
@@ -706 +705 @@
         }
 
         int read_return = -1;
-        if (totfree >= readblocksize && !commserror &&
-            !ateof && !setswitchtonext)
+        if (totfree >= readblocksize && !commserror && !ateof)
         {
             // limit the read size
             totfree = readblocksize;
@@ -842 +840 @@
 
         VERBOSE(VB_FILE|VB_EXTRA, LOC + "@ end of read ahead loop");
 
-        if (readsallowed || commserror || ateof || setswitchtonext ||
+        if (readsallowed || commserror || ateof ||
             (wanttoread <= used && wanttoread > 0))
         {
             // To give other threads a good chance to handle these
@@ -851 +849 @@
             generalWait.wakeAll();
             rwlock.unlock();
             usleep(5 * 1000);
-            rwlock.lockForRead();            
+            rwlock.lockForRead();
         }
         else
         {
             // yield if we have nothing to do...
             if (!request_pause &&
-                (used >= fill_threshold || ateof || setswitchtonext))
+                (used >= fill_threshold || ateof))
             {
                 generalWait.wait(&rwlock, 1000);
             }
@@ -945 +943 @@
         generalWait.wait(&rwlock, 250);
         avail = ReadBufAvail();
 
-        if ((ateof || setswitchtonext) && avail < count)
+        if (ateof && avail < count)
             count = avail;
 
         if (avail < count)
@@ -972 +970 @@
                 }
             }
 
-            bool quit = livetvchain && (livetvchain->NeedsToSwitch() ||
-                                        livetvchain->NeedsToJump() ||
-                                        setswitchtonext);
-
-            if (elapsed > 16000 || quit)
+            if (elapsed > 16000)
             {
-                if (!quit)
-                    VERBOSE(VB_IMPORTANT, LOC_ERR + "Waited " +
+                VERBOSE(VB_IMPORTANT, LOC_ERR + "Waited " +
                             QString("%1").arg(elapsed/1000) +
                             " seconds for data, aborting.");
-                else
-                    VERBOSE(VB_IMPORTANT, LOC + "Timing out wait due to "
-                            "impending livetv switch.");
-
                 return false;
             }
         }