Uses single quotes and QString objects to improve efficiency.

From: Erik Hovland <erik@hovland.org>


---

 mythtv/libs/libmythupnp/httprequest.cpp |    8 ++++----
 mythtv/libs/libmythupnp/ssdp.cpp        |    2 +-
 mythtv/libs/libmythupnp/upnpcds.cpp     |   10 +++++-----
 mythtv/libs/libmythupnp/upnpdevice.cpp  |    6 +++---
 4 files changed, 13 insertions(+), 13 deletions(-)


diff --git a/mythtv/libs/libmythupnp/httprequest.cpp b/mythtv/libs/libmythupnp/httprequest.cpp
index 37b4116..109e4cc 100644
--- a/mythtv/libs/libmythupnp/httprequest.cpp
+++ b/mythtv/libs/libmythupnp/httprequest.cpp
@@ -171,7 +171,7 @@ RequestType HTTPRequest::SetRequestType( const QString &sType )
     if (sType == "UNSUBSCRIBE") return( m_eType = RequestTypeUnsubscribe );
     if (sType == "NOTIFY"     ) return( m_eType = RequestTypeNotify      );
 
-    if (sType.startsWith( "HTTP/" )) return( m_eType = RequestTypeResponse );
+    if (sType.startsWith( QString("HTTP/") )) return( m_eType = RequestTypeResponse );
 
     VERBOSE( VB_UPNP, QString( "HTTPRequest::SentRequestType( %1 ) - returning Unknown." )
                          .arg( sType ) );
@@ -995,7 +995,7 @@ void HTTPRequest::ProcessRequestLine( const QString &sLine )
 
     // ----------------------------------------------------------------------
 
-    if ( sLine.startsWith( "HTTP/" ))
+    if ( sLine.startsWith( QString("HTTP/") ))
         m_eType = RequestTypeResponse;
     else
         m_eType = RequestTypeUnknown;
@@ -1196,8 +1196,8 @@ bool HTTPRequest::ProcessSOAPPayload( const QString &sSOAPAction )
     // XML Document Loaded... now parse it
     // --------------------------------------------------------------
 
-    m_sNameSpace    = sSOAPAction.section( "#", 0, 0).remove( 0, 1);
-    m_sMethod       = sSOAPAction.section( "#", 1 );
+    m_sNameSpace    = sSOAPAction.section( '#', 0, 0).remove( 0, 1);
+    m_sMethod       = sSOAPAction.section( '#', 1 );
     m_sMethod.remove( m_sMethod.length()-1, 1 );
 
     QDomNodeList oNodeList = doc.elementsByTagNameNS( m_sNameSpace, m_sMethod );
diff --git a/mythtv/libs/libmythupnp/ssdp.cpp b/mythtv/libs/libmythupnp/ssdp.cpp
index cb81199..ae3d134 100644
--- a/mythtv/libs/libmythupnp/ssdp.cpp
+++ b/mythtv/libs/libmythupnp/ssdp.cpp
@@ -339,7 +339,7 @@ SSDPRequestType SSDP::ProcessRequestLine( const QString &sLine )
     //      <method> <Resource URI> HTTP/m.n
     // ----------------------------------------------------------------------
 
-    if ( sLine.startsWith( "HTTP/" )) 
+    if ( sLine.startsWith( QString("HTTP/") ))
         return SSDP_MSearchResp;
     else
     {
diff --git a/mythtv/libs/libmythupnp/upnpcds.cpp b/mythtv/libs/libmythupnp/upnpcds.cpp
index bd2f5b9..b63fc9b 100644
--- a/mythtv/libs/libmythupnp/upnpcds.cpp
+++ b/mythtv/libs/libmythupnp/upnpcds.cpp
@@ -232,7 +232,7 @@ void UPnpCDS::HandleBrowse( HTTPRequest *pRequest )
     short          nTotalMatches   = 0;
     short          nUpdateID       = 0;
     QString        sResultXML;
-    FilterMap filter =  (FilterMap) request.m_sFilter.split(",");
+    FilterMap filter =  (FilterMap) request.m_sFilter.split(',');
 
     VERBOSE(VB_UPNP, QString("UPnpCDS::HandleBrowse ObjectID=%1, ContainerId=%2")
 		             .arg(request.m_sObjectId)
@@ -473,7 +473,7 @@ void UPnpCDS::HandleSearch( HTTPRequest *pRequest )
 
         if (eErrorCode == UPnPResult_Success)
         {
-            FilterMap filter =  (FilterMap) request.m_sFilter.split(",");
+            FilterMap filter =  (FilterMap) request.m_sFilter.split(',');
             nNumberReturned = pResult->m_List.count();
             nTotalMatches   = pResult->m_nTotalMatches;
             nUpdateID       = pResult->m_nUpdateID;
@@ -631,7 +631,7 @@ UPnpCDSExtensionResults *UPnpCDSExtension::Browse( UPnpCDSRequest *pRequest )
                     " ", QString::SkipEmptyParts);
                 idPath = idPath[0].split('?', QString::SkipEmptyParts);
 
-                if (idPath[0].startsWith("Id"))
+                if (idPath[0].startsWith(QString("Id")))
                     idPath[0] = QString("item=%1").arg(idPath[0].right(idPath[0].length() - 2));
             }
         }
@@ -643,10 +643,10 @@ UPnpCDSExtensionResults *UPnpCDSExtension::Browse( UPnpCDSRequest *pRequest )
         if (sLast == m_sExtensionId         ) { return( ProcessRoot   ( pRequest, pResults, idPath )); }
         if (sLast == "0"                    ) { return( ProcessAll    ( pRequest, pResults, idPath )); }
 
-        if (sLast.startsWith("key" , Qt::CaseSensitive))
+        if (sLast.startsWith(QString("key") , Qt::CaseSensitive))
             return ProcessKey(pRequest, pResults, idPath);
 
-        if (sLast.startsWith("item", Qt::CaseSensitive))
+        if (sLast.startsWith(QString("item"), Qt::CaseSensitive))
             return ProcessItem(pRequest, pResults, idPath);
 
         int nNodeIdx = sLast.toInt();
diff --git a/mythtv/libs/libmythupnp/upnpdevice.cpp b/mythtv/libs/libmythupnp/upnpdevice.cpp
index 58b5e55..1c2429a 100644
--- a/mythtv/libs/libmythupnp/upnpdevice.cpp
+++ b/mythtv/libs/libmythupnp/upnpdevice.cpp
@@ -377,8 +377,8 @@ void UPnpDeviceDesc::OutputDevice( QTextStream &os,
     // ----------------------------------------------------------------------
 
     bool bIsXbox360 =
-        sUserAgent.startsWith("Xbox/2.0", Qt::CaseInsensitive) ||
-        sUserAgent.startsWith( "Mozilla/4.0", Qt::CaseInsensitive);
+        sUserAgent.startsWith(QString("Xbox/2.0"), Qt::CaseInsensitive) ||
+        sUserAgent.startsWith( QString("Mozilla/4.0"), Qt::CaseInsensitive);
 
     os << FormatValue( "manufacturer" , pDevice->m_sManufacturer    );
     os << FormatValue( "modelURL"     , pDevice->m_sModelURL        );    
@@ -625,7 +625,7 @@ UPnpDeviceDesc *UPnpDeviceDesc::Retrieve( QString &sURL, bool bInQtThread )
                                        NULL,  // login
                                        bInQtThread );
 
-    if (sXml.startsWith( "<?xml" ))
+    if (sXml.startsWith( QString("<?xml") ))
     {
         QString sErrorMsg;
 
