Opened 12 years ago
Closed 12 years ago
#11954 closed Patch - Feature (fixed)
save card input name for recordings
| Reported by: | Owned by: | gigem | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.28 |
| Component: | MythTV - Scheduling | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I've been running this in production for a while without problems. It's pretty straitforward.
I'm not sure if there's a way to retrieve the cardinput for existing recordings to update those rows ex post facto. Suggestions welcome.
The device name isn't saved for live tv recorded rows unless you elect to make them permanent recordings (ie, by pressing "R"). I can't tell if this is a shortcoming on my side or the live tv code.
The patch also includes an update Stuart missed in the perl bindings' outgoing myth protocol message - he updated the incoming code but not the outgoing.
Attachments (10)
Change History (19)
by , 12 years ago
| Attachment: | recinput.schema.patch added |
|---|
by , 12 years ago
| Attachment: | recinput.mythtv.v0.28-pre-461-g1dd14ea.patch added |
|---|
by , 12 years ago
| Attachment: | recinput.mythweb.v0.28-pre-10-gbb41293.patch added |
|---|
by , 12 years ago
| Attachment: | recinput.mythweb.v0.28-pre-9-g61f14b9.patch added |
|---|
supersedes recinput.mythweb.v0.28-pre-10-gbb41293.patch
by , 12 years ago
| Attachment: | recinput.mythtv.v0.28-pre-519-gd8c710d.patch added |
|---|
supercedes recinput.mythtv.v0.28-pre-461-g1dd14ea.patch
comment:1 by , 12 years ago
Apologies for the patch foolishness. I had the wrong branch checked out.
comment:2 by , 12 years ago
| Milestone: | unknown → 0.28 |
|---|---|
| Status: | new → assigned |
comment:3 by , 12 years ago
Looks like this needs a bit more work - the other day I had a failed recording but the tuner was not saved and, of course, failed recording tuner info is the whole point of this. Looks like my assignment isn't early enough in the process so I'm going to take another look and update the patch. Might be a week or two... in between merry making excursions.
comment:4 by , 12 years ago
A brief update: I finally shook loose some time and found a spot to save the input name just after tuning begins which will make it available even when recording ultimately fails. It'll take another week or two to find time to amend the patch, hopefully the timing works out to include this as part of 0.28.
by , 12 years ago
| Attachment: | recinput.mythtv.v0.28-pre-912-g11e65df.patch added |
|---|
supersedes recinput.mythtv.v0.28-pre-719-g8aefe1b.patch
comment:5 by , 12 years ago
I think this patch is ready for review. It still doesn't save the input name for live tv recordings but I don't think that's very important and anyway it's probably a bug in how live tv works.
One subtle change is the recording host is now made available to themes even when a recording fails. When you're analyzing why a recording might have failed in a multi BE setup it's probably helpful to know where the input was located.
by , 12 years ago
| Attachment: | recinput.mythtv.v0.28-pre-1041-ga0a32ef.patch added |
|---|
rebase patch to head as of March 27, 2014
by , 12 years ago
| Attachment: | recinput.mythtv.v0.28-pre-1480-g7265c8f.patch added |
|---|
rebase to reflect recordedid change
by , 12 years ago
| Attachment: | recinput.mythweb.v0.28-pre-22-g9811898.patch added |
|---|
rebase to reflect recordedid change
follow-up: 8 comment:7 by , 12 years ago
| Status: | assigned → infoneeded |
|---|
George, I'm sorry for not getting to this sooner. Thanks for your patches. I took a slightly different approach because I didn't want to add another field to the ProgramInfo object. Could you please revise your mythweb patch to work with this approach?
by , 12 years ago
| Attachment: | recinput.mythweb.v0.28-pre-22-g9811898.2.patch added |
|---|
retrieve input name from recorded
comment:8 by , 12 years ago
Replying to gigem:
Could you please revise your mythweb patch to work with this approach?
Done.
I added a new title when I show the input name on the program's details page but I'm not sure if it's my job to add it to the different *.lang files or that happens automatically after a commit or what. Right now program details shows "!NoTrans: Input Name!!:" which looks unfinished.
comment:9 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | infoneeded → closed |
schema update