Changes between Initial Version and Version 6 of Ticket #12709


Ignore:
Timestamp:
04/07/16 00:57:04 (10 years ago)
Author:
Nicolas Riendeau
Comment:

Replying to rsiddons:

The video player (mythfrontend::main::internal_play_media()) plays video from any source. For instance Gallery uses it for camera videos and MythBrowser and SetupWizard use it for downloaded videos. So it has to fail in a generic/independent way.

"Try it and handle failure" is a more robust strategy than "Check first, do it and handle unexpected failure" (file disappears between check and play ?). It also avoids having to retrieve a remote file twice.

Recordings are a special case. The UI does extra checks on recording files so that they can be marked as missing in the UI. Therefore, it won't even try to play a recording that it already knows is absent.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12709

    • Property Milestone unknown0.28
  • Ticket #12709 – Description

    initial v6  
    1 Reported by Nocolas Riendeau
     1Reported by Nicolas Riendeau, tracked down by Roger Siddons.
    22This is caused by my fix for ticket #12691
    33I will submit a patch shortly.