Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#13361 closed Patch - Bug Fix (fixed)

ChannelUtil::SetVisible function declaration unclear

Reported by: Klaas de Waal Owned by: Klaas de Waal
Priority: minor Milestone: 31.0
Component: MythTV - Channel Scanner Version: Master Head
Severity: low Keywords: DVB channel visible
Cc: stuarta@… Ticket locked: no

Description

The function SetVisible in ChannelUtil.cpp is defined as follows: 

bool ChannelUtil::SetVisible(uint channel_id, bool visible)

The implementation sets the channel visible when the second parameter is true.

However, the declaration of SetVisible in ChannelUtil.h is as follows: 

   static bool    SetVisible(uint channel_id, bool hidden);

This does suggest that when the second parameter is "true" the channel is hidden, i.e. not visible. The attached patch changes "bool hidden" to "bool visible" so that the declaration does match the implementation.

Attachments (1)

20181219_channelutil-setvisible.patch​ (506 bytes ) - added by Klaas de Waal 7 years ago.

Download all attachments as: .zip

Change History (5)

by Klaas de Waal, 7 years ago

Attachment: 20181219_channelutil-setvisible.patch​ added

comment:1 by Klaas de Waal, 7 years ago

Owner: set to Klaas de Waal
Status: new → accepted

comment:2 by Klaas de Waal, 7 years ago

Resolution: → Fixed
Status: accepted → closed

In commit 670b9ea

Fixes #13361 - ChannelUtil::SetVisible function declaration unclear

Signed-off-by: Klaas de Waal <mythtv@…>

comment:3 by Klaas de Waal <mythtv@…>, 7 years ago

Resolution: Fixed → fixed

In 670b9ea14/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:4 by Stuart Auchterlonie, 7 years ago

Milestone: needs_triage → 31.0
Note: See TracTickets for help on using tickets.