id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc	mlocked
13521	videosource table userid cannot be set to NULL	Gary Buhrmaster	gigem	"
While looking at something else, I noticed that in videosource.cpp there is a sql statement that is not correct.  Userid, in the videosource table, is created as NOT NULL.

The failure can probably produce noise in the mythtv-setup logs when one configures videosources, but it is (highly) likely that almost no one looks at the logs from running mythtv-setup unless something really bad happened.

Completely untested.

Proposed patch:

{{{
diff --git a/mythtv/libs/libmythtv/videosource.cpp b/mythtv/libs/libmythtv/videosource.cpp
index d599fd1761..55afc1d512 100644
--- a/mythtv/libs/libmythtv/videosource.cpp
+++ b/mythtv/libs/libmythtv/videosource.cpp
@@ -296,7 +296,7 @@ class XMLTVGrabber : public MythUIComboBoxSetting
         MSqlQuery query(MSqlQuery::InitCon());
         query.prepare(
             ""UPDATE videosource ""
-            ""SET userid=NULL, password=NULL ""
+            ""SET userid='', password=NULL ""
             ""WHERE xmltvgrabber NOT IN ( 'technovera' )"");
         if (!query.exec())
             MythDB::DBError(""XMLTVGrabber::Save"", query);
}}}"	Patch - Bug Fix	closed	minor	31.0	MythTV - General	Master Head	medium	fixed			0