id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc	mlocked
2497	Wrong recording file extension can get used on analog/digital cards	anonymous	danielk	"I have pchdtv5500 (digital/analog card) and I noticed a problem where the wrong recording file extension could be used.  So, you might see .nuv files for digital channels and .mpeg for analog.   

I traced the problem to tv_rec.cpp.  The problem is that a recording is queued (StartedRecording) using the rbFileExt rather than what the current channel's file extension should be.  This is an issue for digital/analog cards because the actual tuning that sets the correct rbFileExt (CreateChannel) is not done until after the recording is queued.  It seems like this is too late to change the extension from what I can see. 

I fixed the problem by retrieving a channel's file extension prior to queueing a recording.  By default, the file extension is be mpg.  Only if a V4l card (using a query that searches for standalone analog or child analog cards) is the file extension changed to nuv.  
I also removed the class rbFileExt and any usage since we will looking up the extension prior to queuing a recording.  

Any comments?"	patch	closed	minor	0.21	mythtv	head	low	invalid			0