Enable song information on changing visualizers

[anonymous]

I didn't like the fact that mythmusic shows only the type of visualizer at song beginning, when the "change the visualizer on each song" option is enabled. I added another option to let mythmusic show either the type of visualizer or the song information if this option is used. Default is to show the song information.

[wilhelm.eger@…]

Updated patch. The first one was malformed.

[stuartm]

I'd rather not add yet another setting. Instead we should just stop showing the visualiser name on automatic changes. I can only see a point in displaying it when you are manually cycling through the visualisers.

[wilhelm.eger@…]

What about showing the song information _and_ the type of visualizer?

[stuartm]

Would anyone fight for the name of the visualizer being shown on automatic changes? I really can't see the value.

[wilhelm.eger@…]

This one?

void PlaybackBoxMusic::CycleVisualizer()
{
    // Only change the visualizer if there is more than 1 visualizer
    // and the user currently has a visualizer active
    if (visual_modes.count() > 1 && visualizer_status > 0)
    {
        if (random_visualizer)
        {
            unsigned int next_visualizer;

            //Find a visual thats not like the previous visual
            do
                next_visualizer = rand() % visual_modes.count();
            while (next_visualizer == current_visual);
            current_visual = next_visualizer;
        }
        else
        {
            //Change to the next selected visual
            current_visual = (current_visual + 1) % visual_modes.count();
        }

        //Change to the new visualizer
        visual_mode_timer->stop();
        mainvisual->setVisual("Blank");
        mainvisual->setVisual(visual_modes[current_visual]);
    }
    else if (visual_modes.count() == 1 && visual_modes[current_visual] == "AlbumArt" &&
             visualizer_status > 0)
    {
        // If only the AlbumArt visualization is selected, then go ahead and
        // restart the visualization.  This will give AlbumArt the opportunity
        // to change images if there are multiple images available.
        visual_mode_timer->stop();
        mainvisual->setVisual("Blank");
        mainvisual->setVisual(visual_modes[current_visual]);
    }
    if (show_cycle_visualizer)
    {
        bannerEnable(tr("Visualization: ") + visual_modes[current_visual], 4000);
    }
    else
    {
        bannerEnable(curMeta, show_album_art);
    }
}

[stuartm]

(In [13580]) Closes #3442

Don't show the visualisation name in the banner when changing it automatically.