mythmusic file scan does not detect compilations

[anonymous]

The mythmusic file scanner does not detection compilation albums. The function MetaIOTagLib::read looks for the musicbrainz id tag (MYTH_MUSICBRAINZ_ALBUMARTIST_UUID) in the id3v2 header. Specifically it looks for 89ad4ac3-39f7-470e-963a-56509c546377. The line in MetaIOTagLib::read TStringToQString(musicbrainz->toString()) actually returns Album Artist Id 89ad4ac3-39f7-470e-963a-56509c546377

The attached patch uses the QString contain function to check if the musicbrainz id is contained within the returned string instead of trying to match the whole thing.

[maverik044]

I should add that if the album is already marked as a compilation in the database, there is no issue. This would be the case if it is ripped by mythmusic. In my case, the database got a little messed up, so I cleared everything out in the mythmusic tables, then re-scanned the music collection. I found that it did not detect the album as compilations even though they were originally ripped by mythmusic.

[maverik044]

hmm, cut&paste got modified TStringToQString(musicbrainz->toString()) actually returns SQB MusicBrainz Album Artist Id SQB 89ad4ac3-39f7-470e-963a-56509c546377 where SQB = square bracket, don't know how to make them appear.

[stuartm]

Alternative solution

[stuartm]

Could you please test the attached patch and tell me if that works for you?

[maverik044]

Yes that works too, thanks.

[stuartm]

(In [13862]) Fixes #3697

Correctly identify mp3s tagged as compilations by mythmusic.

Uses fieldList() to access the the content of a UserTextIndentification frame instead of toString() which includes the frame description.