Opened 20 years ago
Closed 20 years ago
#622 closed defect (fixed)
mythweb won't delete renamed recordings
| Reported by: | anonymous | Owned by: | xris |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.19 |
| Component: | mythweb | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
If you have renamed recordings (using mythrename) then mythweb has trouble deleting them. I would guess, without having looked at the code, because it doesn't escape the spaces introduced to the file name.
Attachments (2)
Change History (15)
comment:1 by , 20 years ago
| Owner: | changed from to |
|---|
comment:2 by , 20 years ago
If you can reproduce while running "mythbackend -v network,file,important,general" and attach the part of the log from around the delete, it would help solve this.
comment:3 by , 20 years ago
Actually, make that "mythbackend -v important,general,network,file" since the important would override the network and file since important is explicit so it needs to be first in the list.
comment:4 by , 20 years ago
Just to acknowledge the request for logs. Will provide them when time & opportunity allow.
comment:5 by , 20 years ago
Log attached. I can't actually see anything there relating to the actual deletion of the recording, which was named "Little Women - 2005-07-16, 6-59 AM.mpg".
by , 20 years ago
| Attachment: | mythweb_delete.log added |
|---|
Log produced using mythbackend -v important,general,network,file when deleting renamed file in mythweb
comment:6 by , 20 years ago
| Owner: | changed from to |
|---|
I don't think this has anything to do with the spaces, your log shows that MythWeb isn't even sending the DELETE_RECORDING request to the backend. I think the issue is with lines like the ones below in recorded_programs.php. I'm passing the ticket back to xris since I think this is a MythWeb issue.
if ($_GETdelete && preg_match('/
d+_
d+/', $_GETfile)) {
...
preg_match('/\/(\d+)_(\d+)_\d+\.nuv$/', $_GETfile, $matches);
The first one is the one causing the problem I think, but the second one needs to be fixed also since we now have .mpg files and we also let people rename them via mythrename.pl.
comment:8 by , 20 years ago
/me debates the embarassment of sending a third message in a row. :)
I was logged in that time, but didn't reload this particular tab before posting. :(
comment:9 by , 20 years ago
When I summized that the problem was due to the spaces in the filename, I meant that it was mythweb and not mythbackend that was having problems. It seems that is the case.
If Xris doesn't beat me to it I'll have a patch written in a minute (just need to grab breakfast first).
by , 20 years ago
| Attachment: | mythweb_deletion.diff added |
|---|
Patch changing mythweb deletion to use chanid & starttime instead of filename
comment:10 by , 20 years ago
Patched attached which changes mythweb to use chanid and starttime as the identifier in deletes instead of filename.
N.B. I've commented out an unrelated line which won't work under current SVN because it assumes all recordings use the nuv extension, I couldn't see what meant to be doing anyway. It can be uncommented if I was wrong.
comment:11 by , 20 years ago
I'm probably not understanding what y'all are saying, but thought I'd chime in. I've been using SVN mythweb and mythtv for the past couple months and had no problem using mythweb to delete files that end in .mpg, not .nuv.
comment:12 by , 20 years ago
The deletion problem has nothing to do with the file extension, but how the file is named. Mythweb expects it to follow the default chanid_starttime(_endtime) format. It doesn't allow deletion of recordings which have been renamed such as "Little Women - 2005-07-16, 6-59 AM.mpg"
comment:13 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
It's definitely the spaces causing the issue... Isaac, if it's something I need to do, let me know and send the ticket back. Otherwise, I'll leave it up to you to fix at your leisure.