Opened 16 years ago
Closed 16 years ago
Last modified 16 years ago
#7167 closed defect (fixed)
Check the return value of function calls inside of mythfrontend
| Reported by: | Owned by: | stuartm | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.24 |
| Component: | MythTV - General | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Quite a few UI and configuration calls return a value. Maybe they should be checked?
Attachments (4)
Change History (10)
by , 16 years ago
| Attachment: | programs_mythfrontend-check-return added |
|---|
by , 16 years ago
| Attachment: | programs_mythjobqueue-check-return added |
|---|
Same kind of return value checking in mythjobqueue
by , 16 years ago
| Attachment: | programs_mythlcdserver-check-return added |
|---|
Check the return value of dup2
by , 16 years ago
| Attachment: | programs_mythtv-setup-check-return added |
|---|
Check some return values in mythtv-setup
comment:1 by , 16 years ago
I'd sooner remove the return value of BuildFocusList() than add all those checks. The only time we return false would is when we're missing focusable widgets and that's perfectly valid if the screen works without them. If the screen doesn't work without them then it's a code error, the author has failed to check that the required widgets exist in the theme. So altogether it's redundant for BuildFocusList() to return any value at all.
comment:2 by , 16 years ago
| Milestone: | unknown → 0.24 |
|---|---|
| Owner: | changed from to |
| Status: | new → accepted |
Erik, BuildFocusList no longer returns true/false, so the frontend patch needs updating.
comment:3 by , 16 years ago
(In [23967]) Always check the return of ConnectToMasterServer() in programs/. Patch from Erik Hovland. Refs #7167
comment:4 by , 16 years ago
| Status: | accepted → infoneeded |
|---|
comment:5 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | infoneeded → closed |
No update. (Please feel free to reopen if you get around to this).
comment:6 by , 16 years ago
No sweat. I do have a patch. But I will have to see what it does currently. Thanks for keeping up w/ the ticket.
Check the return value of calls in mythfrontend