Opened 16 years ago
Closed 16 years ago
#7372 closed defect (fixed)
MythDB overriddenSettings access is not thread-safe.
| Reported by: | danielk | Owned by: | danielk |
|---|---|---|---|
| Priority: | major | Milestone: | unknown |
| Component: | MythTV - General | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Not only not thread-safe, but the code could be more efficient as well by putting these overridden settings in the settingsCache when they are created.
Attachments (1)
Change History (3)
by , 16 years ago
| Attachment: | 7372-v1.patch added |
|---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [22779]) Fixes #7372. Makes overriddenSettings use thread-safe.
This also squeezes strings before adding them to the cache to reduce the memory footprint and uses a read-write lock for less blocking when multiple threads use the settings cache at once.
This updates the binary revision, so plugins need to be rebuilt.
Note:
See TracTickets
for help on using tickets.
This patch has not been extensively tested nor has it been benchmarked, use at your own risk.