Changes between Initial Version and Version 2 of Ticket #970


Ignore:
Timestamp:
01/09/06 12:22:13 (20 years ago)
Author:
Nigel
Comment:

Not as simple as I thought:
1) I think the real problem here is that fink's pkg-config is lying.
2) Making the suggested change, which basically inverts the default vs autodetect logic, would basically make the default of newexif="yes" always manifest in the config file. Not what we want

I will try and install Fink on a spare Mac tomorrow and investigate further

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #970

    • Property Owner changed from Isaac Richards to Nigel
    • Property Status new → assigned

  • Ticket #970 – Description

    initial v2  
    11The OSX packager script broke after I installed fink on my mac mini.   Basically, it fails when compiling mythgallery with the new exif flag.   I finally tracked the problem down to the mythplugins configure script, in this section of code:
    2 
     2{{{
    33        if test x`which pkg-config 2>/dev/null` != x"" ; then
    44            if `pkg-config --atleast-version 0.6.9 libexif` ; then
    … …  
    1818            fi
    1919        fi
    20 
     20}}}
    2121Before I installed fink, I did not have pkg-config, so it would go to the else statement and and put the proper line in my config.h.  If I now manually run the 'pkg-config --atleast-version 0.6.9 libexif', I get a 1 for the return code, so the NEW_LIB_EXIF doesn't get set.  Fink installed pkg-config, however fink has an older version of libexif.  Since the osx-packager script downloads the correct version, I do have the "New" libraries available for install.
    2222
    2323The configure script should be rewritten as:
    24 
     24{{{
    2525         if test x"$newexif" = x"yes" ; then
    2626              echo "#define NEW_LIB_EXIF 1" >> \
    … …  
    4040            fi
    4141        fi
    42 
     42}}}
    4343This way, I can force the NEW_LIB_EXIF with the --enable-new-exif flag.  If I don't set that flag, the script will still correctly find it with the pkg-config line.  The reason I think this is a bug is that with the current logic in the configure script, even if you add the flag --enable-new-exif, the configure script will disable that flag with the pkg-config if statement.   If I manually specify --enable-new-exif, I would expect the configure script to honor that setting, if it fails because I don't really have it, that's my own fault.  But it shouldn't unset the flag because one utility can't find the proper library.
    4444
    … …  
    4646
    4747distcc g++ -c -pipe -faltivec -Wall -W -O3 -Wall -Wno-switch -I/nobackup/myth/.osx-packager/build/include -no-cpp-precomp -pipe -fomit-frame-pointer -force_cpusubtype_ALL -Wno-sign-compare -fno-inline-functions -DPIC -fPIC  -D_GNU_SOURCE -DPREFIX=\"/nobackup/myth/.osx-packager/build\" -DUSING_DBOX2 -DHAVE_DVDNAV -D_FILE_OFFSET_BITS=64 -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -DQT_PLUGIN -DQT_SHARED -DQT_ACCESSIBILITY_SUPPORT -I/nobackup/myth/.osx-packager/src/qt-mac-free-3.3.4/mkspecs/default -I. -I../../../../../build/include -I../../../../../build/include -I/usr/kde/3.3/include -I../../../../../build/include -I/nobackup/myth/.osx-packager/src/qt-mac-free-3.3.4/include -I/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers -I/System/Library/Frameworks/AGL.framework/Versions/A/Headers -o galleryutil.o galleryutil.cpp
    48 /nobackup/myth/.osx-packager/build/include/libexif/exif-entry.h: In static
    49    member function `static long int GalleryUtil::getNaturalRotation(const
    50    char*)':
    51 /nobackup/myth/.osx-packager/build/include/libexif/exif-entry.h:61: error: too
    52    few arguments to function `const char* exif_entry_get_value(ExifEntry*,
    53    char*, unsigned int)'
     48/nobackup/myth/.osx-packager/build/include/libexif/exif-entry.h: In static member function `static long int GalleryUtil::getNaturalRotation(const char*)':
     49/nobackup/myth/.osx-packager/build/include/libexif/exif-entry.h:61: error: too few arguments to function `const char* exif_entry_get_value(ExifEntry*, char*, unsigned int)'
    5450galleryutil.cpp:67: error: at this point in file
    5551make[2]: *** [galleryutil.o] Error 1