Opened 14 years ago

Closed 14 years ago

#9952 closed Patch - Bug Fix (fixed)

[PATCH] MythMusic: Correct visualisation drawing

Reported by: Lawrence Rust <lvr@…> Owned by: paulh
Priority: minor Milestone: 0.25
Component: Plugin - MythMusic Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Fix a bug in MainVisual::timeout which results in an empty set of audio samples being passed to the visualisation. This occasionally results in a glitch in the smooth animation and is most noticeable with stereoscope and monoscope which draw flat lines.

Conditionally exclude some code from the monoscope and stereoscape visualisations that can't be reached.

Optimize drawing for monoscope and stereoscape visualisations. This improves the rendering speed and reduces CPU load.

Attachments (1)

0001-MythMusic-Correct-the-visualisation-drawing.patch​ (15.8 KB ) - added by Lawrence Rust <lvr@…> 14 years ago.

Download all attachments as: .zip

Change History (2)

by Lawrence Rust <lvr@…>, 14 years ago

Attachment: 0001-MythMusic-Correct-the-visualisation-drawing.patch​ added

comment:1 by Github, 14 years ago

Milestone: unknown → 0.25
Resolution: → fixed
Status: new → closed

MythMusic: visualiser improvements.

  • Fix a bug in MainVisual::timeout which results in an empty set of audio samples being passed onto the visualisation.
  • Conditionally exclude some code from the monoscope and stereoscope visualisations that can't be reached.
  • Optimize drawing for monoscope and stereoscope visualisations.

Closes #9952.

Signed-off-by: Paul Harrison <pharrison@…>

Branch: master Changeset: dd43ac278871d5a7df2a861a838dc7fd03072923

Note: See TracTickets for help on using tickets.