Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#10003 closed Patch - Bug Fix (Fixed)

MHEG Tuning fix

Reported by: David Matthews <dm@…> Owned by: stuartm
Priority: minor Milestone:
Component: MythTV - Video/OSD Rendering Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch modifies the code used to get a channel index to use the source ID rather than card ID. It simplifies the code a bit but it also fixes a small problem which only seems to have appeared in the current git HEAD. When viewing recordings from BBC1, at least, a periodic message would come up saying "Due to technical difficulties...". This appears because the BBC MHEG code checks to see which regional variation it is running on by looking up various transport and service IDs. If the look-up fails it produces this message. The patch solves this problem.

Attachments (1)

mheg.tuning.patch​ (8.1 KB ) - added by David Matthews <dm@…> 14 years ago.

Download all attachments as: .zip

Change History (6)

by David Matthews <dm@…>, 14 years ago

Attachment: mheg.tuning.patch​ added

comment:1 by stuartm, 14 years ago

Milestone: unknown → 0.24.2
Owner: changed from markk to stuartm
Status: new → accepted

Thank you David, your continued work on MHEG support is much appreciated.

comment:2 by danielk, 14 years ago

It looks like a couple unsigned integers are assigned -1 in this patch...

comment:3 by beirdo, 14 years ago

Resolution: → Fixed
Status: accepted → closed

Committed in 576bcdd7e9443083f971f23cf47d791c617ef0d1 on master

comment:4 by Github, 14 years ago

Fix some uint vs int issues in MHEG handling

Refs #10003

This fixes the comment danielk had on the -1 in a uint.

Branch: master Changeset: c3b546e41788d793c03b218bb38cd7e22f7238cd

comment:5 by stuartm, 14 years ago

Milestone: 0.24.2

Milestone 0.24.2 deleted

Note: See TracTickets for help on using tickets.