Compilation album is never detected

[mythtv@…]

Hi,

due to a bug in metaioid3's function "*MetaIOID3::read" compilation albums are never detected.

In line 310 musicbrainz ALBUMARTIST_UUID is stored in "TStringToQString(musicbrainz->fieldList().back()))" and not in "TStringToQString(musicbrainz->fieldList().front()))" as in the source.

The correct paragraph is below:

---

    if (musicbrainz)
    {
        // If the MusicBrainz ID is the special "Various Artists" ID
        // then compilation is TRUE
        if (!compilation && !musicbrainz->fieldList().isEmpty())
            compilation = (MYTH_MUSICBRAINZ_ALBUMARTIST_UUID
            == TStringToQString(musicbrainz->fieldList().back()));
    }

---

This patch is tested and works.

Christian

[stuartm]

There should be only one string field in that tag, hence front() should work. Can you dump all the fields and see what's being inserted before MYTH_MUSICBRAINZ_ALBUMARTIST_UUID?

Which application was the tagging done in? Mythmusic/Picard/Other?

If some apps are sticking other text in the field it could appear after the UUID as well in which back() would break it for others. We could iterate over all fields checking each but if it's mythmusic inserting the bad data then we should fix that instead.

[okuehn@…]

Replying to stuartm: I'm facing the same issue and can reproduce with both, file being tagged by mythmusic during import or tagged by app mp3tag. Which additional debug information would be helpful?

Oliver

[Paul Harrison <pharrison@…>]

In 6530ac633300a32c76db0d10cf8d107aa712a62c/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[Paul Harrison <pharrison@…>]

In 4c12503a741c5e2fa199eac414e4bafe53d51c12/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available