Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#1053 closed patch (fixed)

Help text in for FreqID is incorrect (patch attached)

Reported by: gjhurlbu@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

in mythtv/libmythtv/channelsettings.cpp, line 192, the freqid help states to use the exact frequency in Hz. However, the value is actually in kHz. This will confuse people.

Patch is attached to fix it.

Attachments (2)

kHz-text.patch​ (569 bytes ) - added by gjhurlbu@… 20 years ago.
patch to fix the text mentioned.
kHz-text.2.patch​ (875 bytes ) - added by gjhurlbu@… 20 years ago.
patch to fix the text mentioned (revised)

Download all attachments as: .zip

Change History (6)

by gjhurlbu@…, 20 years ago

Attachment: kHz-text.patch​ added

patch to fix the text mentioned.

comment:1 by gjhurlbu@…, 20 years ago

OK, on second glance, the same issue is in the Finetune right after it. Updated the patch.

by gjhurlbu@…, 20 years ago

Attachment: kHz-text.2.patch​ added

patch to fix the text mentioned (revised)

comment:2 by beirdo, 20 years ago

Resolution: → fixed
Status: new → closed

(In [8632]) Changed the help text for Finetune and Freqid to state kHz rather than Hertz. Closes #1053

comment:3 by danielk, 20 years ago

(In [8651]) Fixes #1053.

In this case an MPEG-4 recording is using a frame height which is not a multiple of 16. ffmpeg isn't doing any validation on the dimensions so it ends up writing outside the buffer. This just pads allocated buffers up to multiples of 16, so that this type of error doesn't cause a segfault with any of the codecs we support. MythTV does prevent you from setting an invalid dimension when you record to a MPEG-4 NUV, so AFAIK this is more of a legacy issue.

comment:4 by danielk, 20 years ago

Sorry, [8651] references #1052, not #1053.

Note: See TracTickets for help on using tickets.