[PATCH] Fix PiP playback with Xv

[Lawrence Rust <lvr@…>]

When using Xv-blit video output and trying to view two or more programs using PiP then the inset video often flickers or contains elements of 2 unrelated frames.

When displaying 'pictute in picture' (PiP), VideoOutput::ShowPIP composites the PiP windows onto the main video frame. To do so, it uses the player's GetCurrentFrame method to obtain the most recently displayed PiP frame. However, MythPlayer::DisplayNormalFrames immediately releases the last frame displayed back to the decoding queue. Consequently when GetCurrentFrame calls GetLastShownFrame to obtain that frame it may have been overwritten by the decoder thread.

This patch defers calling DoneDisplayingFrame if the player is a PiP player so that future calls to GetLastShownFrame return an intact frame.

This patch is for git master but is equally applicable to fixes 0.25 and 0.24

[davidriggleman@…]

Are there any plans to integrate this into master? I'm seeing similar flickering in PiP and it sounds like it's related to this bug. It looks like the patch code fix would still work the same, at least in 0.27.

[JYA]

issue isn't just with Xv, but also opengl and any software rendered output.

Thank you for the patch

Fixed in 49df62f1a76f0e617208e261a09f5f8a634b3ce9

[Lawrence Rust <lvr@…>]

In 4d7b305afc071addb06b566ac1d9fbadd431c741/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available