Convert to using MARK_GOP_BYFRAME instead of MARK_GOP_START

[adeffs@…]

as seen in ​http://www.gossamer-threads.com/lists/mythtv/dev/170636

mythcommflag rebuild does not properly rebuild the seek table resulting in extra short length reporting and jumping around doesn't work properly.

daniel.chassot at gmail has a "fix" that works, but may cause other problems: looking in avformatdecoder.cpp around line 794, I found that the keyframe distance is initially set to 15 except for AVI file because the avi keyframes are too irregular. As it seems to be my problem too for my DVB recordings, I've commented out the line 794: if (!strcmp(fmt->name, "avi")).

[bolek-mythtv@…]

Also discussed in

​http://www.gossamer-threads.com/lists/mythtv/dev/173198 ​http://www.gossamer-threads.com/lists/mythtv/dev/173742

[danielk]

We should just get rid of MARK_GOP_START altogether and always use MARK_GOP_BYFRAME which will work with all MPEG recordings.

[maverik044]

Here's my go at the patch. Patch is attached in three parts.

1. gopbyframe.diff I've been able to test. It works works with videos and recordings I have. It works with DVD's I've tested. It fixes the problem of mythcommflag generating incorrect position maps for mpeg files and recordings. This fixes FFW/REW Seeking on mpeg files that have NO position map and that the keyframedist is not constant, but still will want to have a position map as the picture is blocky in FFW and REW.

2. mpegrec_gopbyframe.diff changes the mpeg recorder to use a keyframedist of 1. I have no way of testing this, this is why it is separate. I noted that the other recorders seem to already use MARK_GOP_BYFRAME, so no changes needed.

3. ivtv_gopbyframe.diff changes ivtvdecoder.cpp to use MARK_GOP_BYFRAME and keyframedist of 1 if there is no position map. Again I have no way to test this, so it is also separate.

There's some code in decoderbase.cpp in PosMapFromEnc that could be removed if all three diff files are used. This is further code in decoderbase.cpp and avformatdecoder.cpp that is only needed to support old database position maps of type MARK_GOP_START.

[danielk]

fix for mpegrecorder

[danielk]

The patch I've just attached is lightly tested. I'll be applying it to my production machine to give it decent workout. It just uses MARK_GOP_BYFRAME in the mpegrecorder rather than MARK_GOP_START to avoid creating any new recordings employing MARK_GOP_START...

[danielk]

(In [17826]) Fixes #5462. Refs #1088. Use MARK_GOP_BYFRAME for PS recordings in MPEGRecorder.

[Janne Grunau]

(In [18854]) convert avformatdecoder seektables from MARK_GOP_START to MARK_GOP_BYFRAME. Refs #1088

[Janne Grunau]

(In [19242]) remove last active use of MARK_GOP_START. Fixes #1088