Opened 14 years ago
Closed 13 years ago
Last modified 13 years ago
#11111 closed Patch - Bug Fix (Fixed)
Fix UUID generation in UPNP
| Reported by: | Owned by: | stuartm | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | MythTV - UPnP | Version: | Master Head |
| Severity: | medium | Keywords: | upnp fix udn |
| Cc: | Ticket locked: | no |
Description
currently LookupUDN() will generate invalid UUID which is then used to generate a invalid UDN. this may cause problems with UPNP devices that parses the UDN - resulting in failed discovery.
Currently LookupUDN() generates UUID like this:
"{74c5afe6-181b-46b1-9a4b-ae9e53d0e47"
this results in a UDN looking like this:
"uuid:{74c5afe6-181b-46b1-9a4b-ae9e53d0e47"
The patch changes the code to remove the leading '{' and trailing '}' maiing the UUID look like this:
"74c5afe6-181b-46b1-9a4b-ae9e53d0e479"
and a valid UDN:
"uuid:74c5afe6-181b-46b1-9a4b-ae9e53d0e479"
Attachments (2)
Change History (8)
by , 14 years ago
| Attachment: | mythtv_upnp_fix_uuid_generation.patch added |
|---|
comment:1 by , 14 years ago
Nope sorry no change. I even recompiled every thing.
upnp-inspector
does not even acknowledge myth as upnp device even though it is on the same pc as the mythbackend.
comment:2 by , 14 years ago
<?xml version="1.0" encoding="utf-8"?> <root xmlns="urn:schemas-upnp-org:device-1-0" xmlns:mythtv="mythtv.org"> <specVersion> <major>1</major> <minor>0</minor> </specVersion> <URLBase>http://<Server IP hidden by me>:6544/</URLBase> <device> <deviceType>urn:schemas-upnp-org:device:MediaServer:1</deviceType> <friendlyName>mythdvr: MythTV AV Media Server</friendlyName> <manufacturer>MythTV</manufacturer> <modelURL>http://www.mythtv.org/</modelURL> <modelName>MythTV AV Media Server</modelName> <manufacturerURL>http://www.mythtv.org/</manufacturerURL> <modelDescription>MythTV AV Media Server</modelDescription> <modelNumber>0.26.20120822-1</modelNumber> <serialNumber>v0.26-rc2-30-g272fb61-dirty</serialNumber> <presentationURL>/</presentationURL> <mythtv:X_secure>false</mythtv:X_secure> <mythtv:X_protocol>75</mythtv:X_protocol> <dlna:X_DLNADOC xmlns:dlna="urn:schemas-dlna-org:device-1-0">DMS-1.00</dlna:X_DLNADOC> <UDN>uuid:0705d747-7b55-415d-b2cf-d9517014cb7d</UDN> <serviceList> <service> <serviceType>urn:schemas-upnp-org:service:ConnectionManager:1</serviceType> <serviceId>urn:upnp-org:serviceId:CMGR_1-0</serviceId> <SCPDURL>CMGR_Control/GetServDesc</SCPDURL> <controlURL>CMGR_Control</controlURL> <eventSubURL>CMGR_Event</eventSubURL> </service> <service> <serviceType>urn:schemas-upnp-org:service:ContentDirectory:1</serviceType> <serviceId>urn:upnp-org:serviceId:CDS_1-0</serviceId> <SCPDURL>CDS_Control/GetServDesc</SCPDURL> <controlURL>CDS_Control</controlURL> <eventSubURL>CDS_Event</eventSubURL> </service> </serviceList> </device> </root>
comment:3 by , 13 years ago
| Milestone: | unknown → 0.27 |
|---|---|
| Owner: | changed from to |
| Status: | new → accepted |
comment:4 by , 13 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | accepted → closed |
In 6a172c5b70f24cb1daa6123f3a67acd5a3fcd056/mythtv:
Fix UUID. QUuid returns the UUID encapsulated in braces which need to be stripped before it can be used for upnp. Fix #11111

fix UUID generation - applies to MASTER and 0.25