Closing a screen when using the Qt painter can segfault

[paulh <mythtv@…>]

This has been observed when closing the volume popup in MythMusic but could affect any screen. To reproduce change to the Qt painter then:-

1. Change the volume in MythMusic which shows the volume popup dialog.
2. Immediately press ESCAPE to close the dialog.

What's happening is

1. The keypressEvent gets passed to MythMusicVolumeDialog::keyPressEvent() which in turn passes it to MythScreenType::keyPressEvent()

2. MythScreenType::keyPressEvent() then calls MythScreenType::Close() which then calls MythScreenStack::PopScreen()

3. Because we are using the Qt painter there is no fade effect or animation to do so the screen gets deleted right away in PopScreen().

4. At this point we return to MythMusicVolumeDialog::keyPressEvent() of the now deleted screen where any access to any members is going to segfault which is what happens in this case.

A simple generic fix would be to change in MythScreenStack::PopScreen()

delete screen;

to

screen->deleteLater();

so the keypressEvent handlers could complete safely before the screen is eventually deleted when control returns to the event loop.

[paulh <mythtv@…>]

This has been confirmed to fix the segfault ​https://github.com/paul-h/mythtv/commit/1b92f4c277

[Paul Harrison <mythtv@…>]

In c713988707d2c795a2a2abeff817d1b187d4b3f6/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[Paul Harrison <mythtv@…>]

In d1a48313dac5510795250c783bca2fe56ee6d7b1/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available