Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#11455 closed Bug Report - General (fixed)

DVD subpictures without an explicit 'end' time are not shown.

Reported by: peper03@… Owned by: peper03
Priority: minor Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The 'end' time for DVD subpictures defaults to zero, which prevents them being shown if they don't include an explicit command to set it.

The attached patch initializes the 'end' time so that the subpicture shows forever (or until the next subpicture). This allows DVDs such as those found ​here to play (note subtitles must be turned on to see anything!)

Additionally, the also adds minimal handling for the 'CHG_COLCON' command, which doesn't occur often, but is currently not recognised. This could lead to issues due to the code attempting to interpret the data for the command as new commands. The new handling simply skips over the data to the next command.

Attachments (3)

0001-Ensure-that-DVD-subpictures-that-don-t-explicitly-se.patch​ (2.1 KB ) - added by peper03@… 13 years ago.
0001a-Ensure-that-DVD-subpictures-that-don-t-explicitly-se.patch​ (3.0 KB ) - added by peper03@… 13 years ago.
Updated patch
0001b-Ensure-that-DVD-subpictures-that-don-t-explicitly-se.patch​ (3.5 KB ) - added by peper03@… 13 years ago.

Download all attachments as: .zip

Change History (10)

by peper03@…, 13 years ago

Attachment: 0001-Ensure-that-DVD-subpictures-that-don-t-explicitly-se.patch​ added

by peper03@…, 13 years ago

Attachment: 0001a-Ensure-that-DVD-subpictures-that-don-t-explicitly-se.patch​ added

Updated patch

comment:1 by peper03@…, 13 years ago

The updated patch initializes end_display_time to the same value as start_display_time.

Also, the number of subtitles that can be buffered is increased to 40 to (hopefully) allow as many subtitles to be buffered as video frames (OpenGL on my machine buffers 29 frames, so for full frame-rate subtitles/subpictures, it must be possible to buffer the same number of subtitles).

Note that the patch from #11451 must be applied before either of these patches.

comment:2 by Jim Stichnoth, 13 years ago

Owner: set to Jim Stichnoth
Status: new → accepted

by peper03@…, 13 years ago

Attachment: 0001b-Ensure-that-DVD-subpictures-that-don-t-explicitly-se.patch​ added

comment:3 by peper03@…, 13 years ago

New patch (0001b) adds a check to ensure that an end time has actually been set before clearing a menu highlight. Otherwise the highlight would only appear for one frame on menus where no end time was specified.

comment:4 by Jim Stichnoth, 12 years ago

Owner: changed from Jim Stichnoth to peper03
Status: accepted → assigned

comment:5 by Richard <peper03@…>, 12 years ago

Resolution: → fixed
Status: assigned → closed

In e5e9cc8ce4841c233db9604d3296e243aa0a3e54/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:6 by peper03, 12 years ago

Milestone: unknown → 0.27

comment:7 by Richard Hulme <peper03@…>, 12 years ago

In 811be23159604626ee8675400692cccc4599229f/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available
Note: See TracTickets for help on using tickets.