Opened 13 years ago

Closed 13 years ago

#11477 closed Patch - Bug Fix (Fixed)

Make MythCenter theme consistent with MythCenter-wide

Reported by: faginbagin <mythtv@…> Owned by: paulh
Priority: minor Milestone: 0.27
Component: Themes Version: 0.26-fixes
Severity: medium Keywords: UI consistency
Cc: Ticket locked: no

Description

If you're like me, you've got a mix of SD and HD displays as part of your mythtv environment. In our home, we've still got an SDTV connected to a GT-9500 and a monitor with a native resolution of 1280x1024, as well as a a couple of laptops made in 2004 that have 1400x1024 resolutions. What I've always wanted was an SD theme that had the same look and feel as an HD theme, so that, no matter which frontend you were using, you would know what to expect. That was more or less true with the MythCenter and MythCenter-wide themes in mythtv 0.23. But that's no longer true as of 0.25. The big difference between these two themes is the OSD. Through 0.23, you could mix and match your main theme and your OSD theme. As of 0.25, the OSD theme is now part of the main theme. Unfortunately, the MythCenter and MythCenter-wide themes have very different OSDs.

I have updated the MythCenter theme so it's OSD is consistent with the MythCenter-wide theme's OSD. While I was at it, I have made other improvements to the MythCenter theme. For example:

  • When you're in the Program Guide, you can see both the channel numbers and call signs, as well as the channel icons.
  • When you're in the Program Finder, you can see the time a show is scheduled, including whether its in the AM or PM.
  • When you schedule a recording, the options presented on the main page now fit on the screen. As a result, you will know if you're choosing "Record one showing of this title every week" vs "Record one showing of this title every day". Or if you're choosing "Record at any time on this channel" vs "record at any time on any channel". The same is true for the various sub-pages.
  • When you're in Watch Recordings: both time and date of recordings fit on the list, at a variety of different resolutions; you can now see the watched status of recordings on the list, as well as other status indicators, like whether the recording is on a slave backend that may or may not be up and running.

There are many other improvements, but I think these are the most obvious ones. I have been through every window defined in every .xml files and tested any changes I made at these resolutions:

  • 800x600
  • 1024x768
  • 1280x1024
  • 1400x1024

Dates and times were tested using settings that should look reasonable regardless of whether its a single digit or double digit month or day. For example, I used the short date setting of "02/04" versus "2/4" and the time setting of "05:58 PM" vs "5:58 pm"

Since I only speak one language, I have not tested my changes in other languages. But I suspect, if anything, my changes will be improvements in any language, because, in general, more space is provided for various text elements than before. If I'm wrong, I'd be happy to work with anyone who finds my changes less than helpful.

If you'd like to try my version of MythCenter, you've got two choices:

  • Untar MythCenter-custom.tgz in your $HOME/.mythtv/themes directory, then go to Setup -> Theme Chooser, and change the theme to "MythCenter-custom 1.2" This will allow you to go back and forth between the current MythCenter themes and my version.
  • Apply the patch MythCenter-like-wide.patch, build and install. In this case, the theme name will be MythCenter, although the version has been bumped to 1.2

FWIW my changes are up-to-date with the most recent change made to the theme that fixes ticket:10614.

Attachments (2)

MythCenter-like-wide.patch (233.5 KB ) - added by faginbagin <mythtv@…> 13 years ago.
Patch
MythCenter-custom.tgz (1.6 MB ) - added by faginbagin <mythtv@…> 13 years ago.
To be untarred in $HOME/.mythtv/themes

Download all attachments as: .zip

Change History (16)

by faginbagin <mythtv@…>, 13 years ago

Attachment: MythCenter-like-wide.patch added

Patch

by faginbagin <mythtv@…>, 13 years ago

Attachment: MythCenter-custom.tgz added

To be untarred in $HOME/.mythtv/themes

comment:1 by paulh, 13 years ago

Owner: set to paulh
Status: newassigned

Thanks for looking at this Helen making both the MythCenter themes consistent was something discussed among the developers recently so your patch is very welcome :)

Unfortunately changes between master and fixes-0.26 mean the patch doesn't apply cleanly so it's going to require a little work to clean it up.

comment:2 by Paul Harrison <pharrison@…>, 13 years ago

In 4dfc0df5e5076d65a68158edf5a391d5d63af563/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:3 by Paul Harrison <pharrison@…>, 13 years ago

In 2d352916274c5ab60965d916a5c79c8a8f95c89f/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:4 by Paul Harrison <pharrison@…>, 13 years ago

In 6b9a22fb5c7412e1a5436266fbd44d866853619b/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:5 by Paul Harrison <pharrison@…>, 13 years ago

In bed72ed86999191335afc3a4d54e1880c07fad2a/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:6 by Paul Harrison <pharrison@…>, 13 years ago

In ae712db3bd7b4e326365232bae4955064e25e12c/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:7 by Paul Harrison <pharrison@…>, 13 years ago

In 90a42603458102f0adea2939fa78473cba09abfe/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:8 by Paul Harrison <pharrison@…>, 13 years ago

In 7737fd70b7ac6fdd92ef989a97efdeb93cd881c8/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:9 by Paul Harrison <pharrison@…>, 13 years ago

In ef7bc63af0c1468634f32d6bbae0972cd9a0d2b2/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:10 by Paul Harrison <pharrison@…>, 13 years ago

In ca4bfa09ccc834e299886a0bff5865e76ac3fa79/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:11 by Paul Harrison <pharrison@…>, 13 years ago

In fd0a67bcf9dae9e7f2d00785605a9c557d2b714f/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:12 by Paul Harrison <pharrison@…>, 13 years ago

In 35aa081966e34e8f0cf38f111e9b6e7bb45bfc0a/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:13 by Paul Harrison <pharrison@…>, 13 years ago

In 21c75b421df9aae93bb5872441bfe8f195e87e81/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:14 by paulh, 13 years ago

Milestone: unknown0.27
Resolution: Fixed
Status: assignedclosed

I think this is looking OK, there was a few issues because of the changes between master and fixes but I think I've found and fixed then all. If you spot anything I've missed let me know and I'll fix it.

Note: See TracTickets for help on using tickets.