Opened 13 years ago

Closed 13 years ago

#11550 closed Patch - Bug Fix (fixed)

Patch for static analysis detected array index undefined in dvdringbuf.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (scan-build) detected a potential code path that would result in calling guess_palette with the palette array not having been initialized, and indexing m_clut with an undefined value. This patch initializes the arrays.

​https://github.com/garybuhrmaster/mythtv/commit/824013456f41f4c90daa1f1a3879a1c9e06c28c5

Change History (4)

comment:1 by Gary Buhrmaster <gary.buhrmaster@…>, 13 years ago

btw, this patch also fixes the static analysis detected alpha value (potentially) being uninitialized and passed to guess_palette, where it is used in a calculation.

comment:2 by Gary Buhrmaster <gary.buhrmaster@…>, 13 years ago

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: → fixed
Status: new → closed

In b578a5e6444ee5d04c00387d233ab79ddba691a3/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:3 by stuartm, 13 years ago

Milestone: unknown → 0.27
Resolution: fixed
Status: closed → new

comment:4 by Gary Buhrmaster <gary.buhrmaster@…>, 13 years ago

Resolution: → fixed
Status: new → closed

In ab1f79a25ae33a0451a197bd3733767a2591dbfc/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available
Note: See TracTickets for help on using tickets.