Opened 13 years ago
Closed 10 years ago
#11678 closed Bug Report - General (Fixed)
Video metadata downloads the least popular fanart from tmdb
| Reported by: | Owned by: | Raymond Wagner | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27.5 |
| Component: | MythTV - General | Version: | Unspecified |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
This is seen with current master. It has been an issue for well over a year as well. I have seen at least one other person mention this on the users list and it was dismissed as a false report.
When a query to tmdb returns multiple rows for fanart, the last one is downloaded and used. This is the lowest rated from tmdb and should not be the one used.
Simply changing tmdp3.py to use m.images.insert(0,{...}) rather than m.images.append({...}) (reverses the sort) for fanart results in the proper image being used. I assume, however, that the fix should actually be in myth's code. Coverart also uses the append method and the first item is downloaded in that case.
On another note, if you reset all metadata for a video, it does not delete the existing fanart. When you then retrieve details, it also does not overwrite the existing image. Unless you manually delete the image, you cannot replace it with an updated one. To refresh an image, one has to both delete the fanart file and clear their themecache entry which is cumbersome.
Change History (7)
comment:1 by , 13 years ago
| Milestone: | unknown → 0.26.1 |
|---|---|
| Owner: | set to |
| Status: | new → accepted |
comment:2 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
comment:4 by , 12 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
There are reports of this issue still existing. I'm re-opening this so I don't forget it when I have a chance to look into it again.
comment:5 by , 11 years ago
Please see #12246 for troubleshooting and solution (essentially, reverting this commit fixes it).
comment:6 by , 11 years ago
| Milestone: | 0.26.1 → 0.27.6 |
|---|
comment:7 by , 10 years ago
| Milestone: | 0.27.6 → 0.27.5 |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
As per comment:5 this has been fixed by reverting the fix that fixed it. (We fixed one wrong of two wrongs that did make one right, thus making it wrong. Oh my this is confusing. The results were being reversed in multiple places.)
Lets track the issue with caching the old image separately, maybe in #12274. The image order issue is confusing enough without it.
In da8ac305c3dbe955459a6a12e646b81109552836/mythtv: