Opened 13 years ago
Closed 11 years ago
Last modified 11 years ago
#11713 closed Developer Task (Fixed)
add mythical bookmark at the scheduled start of programme (to automatically skip preroll)
| Reported by: | Karl Egly | Owned by: | Jim Stichnoth |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.28 |
| Component: | MythTV - Recording | Version: | Unspecified |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description (last modified by )
As there may be or not be soft padding applied to recordings it would be nice to be able to start watching recordings at the scheduled beginning of the programme.
http://irc.mythtv.org/ircLog/channel/4/2013-07-29:18:34/2013-07-29:18:54
(I don't know that area of the code base. So if anyone else gets to it first that's fine.)
Attachments (3)
Change History (18)
comment:1 by , 12 years ago
| Milestone: | 0.27.2 → 0.27.5 |
|---|
comment:3 by , 11 years ago
comment:4 by , 11 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → accepted |
After some more thought, here's the current plan.
Add a new value MARK_UTIL_PREROLL to MarkTypes.
RecorderBase::SavePositionMap() writes this mark as soon as it encounters a keyframe close to the recording's scheduled start time.
The frontend PBB starts playback from this keyframe if the user selects Play and there is no explicit bookmark (but not if the user selects one of the "Play from..." menu items).
I also want another "utility mark" mechanism:
Add a new value MARK_UTIL_PLAYPOS to MarkTypes.
The TV class (tv_play.cpp) adds a timer event that auto-saves the current playback frame with this mark type every 30 seconds. The actual saving is done in a background thread to avoid playback glitches.
The "Play from..." menu gets a new item:
Play from last played position
If you accidentally exit playback without setting a bookmark (or mythfrontend crashes, or the OS crashes, or ...), this allows you to resume roughly where you left off.
by , 11 years ago
| Attachment: | 11713_v1.patch added |
|---|
comment:5 by , 11 years ago
I'll be trying out 11713_v1.patch for several days before committing. Other testers/feedback appreciated.
by , 11 years ago
| Attachment: | 11713_v2.patch added |
|---|
Rename preroll==>progstart, and playpos==>lastplaypos.
comment:7 by , 11 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | accepted → closed |
comment:12 by , 11 years ago
| Milestone: | 0.27.5 → 0.28 |
|---|
comment:13 by , 11 years ago
I hadn't rebuilt master since the qt5 switch, so hadn't noticed this.
I cut most of my recordings with the intention of letting me see the parts I want. Now playback starts two minutes late. That is the duration of my specified pre-roll. For me the scheduled start time is rarely a good guide to reality.
My cutting script clears the cutlist and marks its output as transcoded; I believe that the 'lossless' mythtranscode does the same. If this commit is still thought useful it ought to be disabled for cases like that.
http://www.gossamer-threads.com/lists/mythtv/users/588641#588641
by , 11 years ago
| Attachment: | 0001-Add-utility-function-to-clear-all-bookmarks.patch added |
|---|
proof of concept (compile tested) implementing the suggestion from the mailing list discussion
comment:14 by , 11 years ago
Yes, that patch and its explanation look good and likely to let me solve the late-start-of-playback effect I'm seeing with output from my current mythDVBcut script. I'm afraid I don't see my way to testing it anytime soon, though. No experience yet in *buntu builds - nor with recent master and el7 clones.
Thanks.
Also this:
http://irc.mythtv.org/ircLog/channel/4/2013-07-29:19:56:32/2013-07-29:19:57:25