Dvr/AddRecordSchedule does not work

[robert.mcnamara@…]

The reworked AddRecordSchedule does not work (and as near as I can tell never has). RecordingRule::isValid is called on the recording rule constructed, but the rule's start and end times and dates are never set. Thus, the duration will always be 0 and isValid will return false. Presumably adding (to Dvr::AddRecordSchedule):

rule.m_startdate = recstartts.date(); rule.m_starttime = recstartts.time();

rule.m_enddate = recendts.date(); rule.m_endtime = recendts.time();

Will cause this to function as expected.

On an slightly related note, It's a serious bummer to have existing API calls reworked like this rather than replaced and the old ones deprecated-- anyone who has written a client against the existing API is in for a rude awakening when .27 is released.

[robert.mcnamara@…]

Ref #11495

[David Engel <dengel@…>]

In f64d715b30ca7a52359855e00d4d842487ba6dfa/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[gigem]

The services API is still very immature and subject to change between MythTV versions. I expect it will remain that way until we begin to use the API ourselves and have a well defined policy and method for providing backward compatibility. In the case of AddRecordSchedule(), the old version was broken by design and was not something I wanted to keep around.

[robert.mcnamara@…]

With the above resolved, AddRecordSchedule still does not work. It does not set the ChanId in the recording rule and thus isValid fails because the chanId is invalid.

[David Engel <dengel@…>]

In 763c7caff6d05e36064765de1133e51cf1a5ec0e/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available