Opened 13 years ago

Closed 11 years ago

Last modified 10 years ago

#11839 closed Patch - Feature (fixed)

Qt5 feature patch to resolve signed vs unsigned comparision warning for QKeySequence count type change

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: trivial Milestone: 0.28
Component: MythTV - User Interface Library Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Qt5 has been released, and some distros are starting to provide it as an alternative to Qt4, although I would not expect Qt5 to be the default for quite some time. Regardless, one of the changes in Qt5 is changing the type of QKeySequence count() from uint to int. This patch uses the correct type for variable in the for loop in order to avoid a signed vs unsigned comparison warning at compile time, and as it is surrounded by a version check should be safe for any supported Qt version, and prepares MythTV for the inevitable Qt5 default on some distro at some future date (probably a few years from now) with no additional compilation warnings.

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/dcc1fa914cf2614543bb274da6faa8a6db543946

github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/dcc1fa914cf2614543bb274da6faa8a6db543946.patch

Change History (2)

comment:1 by Gary Buhrmaster <gary.buhrmaster@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 585c04077b556445cae42e763c17d7bd8c18b854/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:2 by Karl Egly, 10 years ago

Milestone: unknown → 0.28
Note: See TracTickets for help on using tickets.