Opened 13 years ago
Closed 12 years ago
#11966 closed Patch - Bug Fix (Fixed)
Patch -- libc++ v libstdc++
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - General | Version: | 0.27-fixes |
| Severity: | medium | Keywords: | clang libc++ libstdc++ |
| Cc: | Ticket locked: | no |
Description
Clang, in Apple's XCode 5, was recently updated to use libc++ instead of libstdc++. libc++ is slightly more strict and detected issues with three files; patch attached.
I am not a C/C++ developer, however. ( I am especially unsure of the change to mythpainter.cpp.) Nonetheless, I'm submitting this patch as I think someone more experienced should be able to figure out the correct approach without difficulty.
Attachments (4)
Change History (9)
by , 13 years ago
| Attachment: | patch-various_c++_v_stdc++.diff added |
|---|
by , 13 years ago
| Attachment: | patch-various_c++_v_stdc++_v2.diff added |
|---|
by , 13 years ago
| Attachment: | 27 build fail onMavericks 2013Nov28_01.txt added |
|---|
mythpainter.cpp error, see line 4962
comment:2 by , 13 years ago
Sorry, apparently I didn't save the logs from the mythgesture.cpp and mythuisimpletext.cpp.
by , 13 years ago
| Attachment: | 27 build fail onMavericks mythgesture.cpp.txt added |
|---|
mythgesture.cpp error, see line 1638
comment:3 by , 13 years ago
I've recreated the error in mythgesture.cpp and attached a log.
Can't seem to replicate the failure in mythuisimpletext.cpp!?! Strange.
comment:4 by , 12 years ago
Please close this ticket, the issue was fixed in:
https://github.com/MythTV/mythtv/commit/f5e61804d7a8ad6afc4aa4484e2c05f24ddb396b
comment:5 by , 12 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | infoneeded_new → closed |
closing as fixed at reporters request.
We need to see the actual compilation/linking errors, especially for mythuisimpletext.cpp since it doesn't even use std::abs directly.
I'll add a slightly different patch for the other two files.