Patch: Prevent an invalid combination of logging options and adjust the --help output

[Bill Meek <keemllib@…>]

According to mythAnyCommand --help nologserver (changeset:f124159):

Description: Disable all logging but console.

However, the three options in the above Summary are allowed. If used, then mythlogserver is started, however nothing is sent to the logs or the database (only the console, as expected.)

This patch will prevent the invalid combination and cause the following to be added to --help nologserver output:

Prevents the use of:
 --logpath --syslog --enable-dblog

[Bill Meek <keemllib@…>]

Patch tested on: v0.28-pre-655-g7f3d8f7

[Bill Meek <keemllib@…>]

In be72636b9e34b1b9fb032a1da578a742d562d0b9/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[Bill Meek <keemllib@…>]

In ec06dfba8e22008ac97af81f997e9b521eca62ae/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[JYA]

this ticket and description is wrong.

--nologserver prevent that a mythlogserver daemon is forked and run in the background.

Instead, logs are processed within a separate thread which log all the logs.

running a myth application with --nologserver is identical to compiling mythtv with --disable-mythlogserver

except of course , should people want to, they can still run mythlogserver daemon

[JYA]

IMHO, the bug is in the description of what --nologserver is supposed to do.

[Paul Harrison <pharrison@…>]

In 9a72d02cb7e9a89135b5044e9179f148a45b0cf6/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[Bill Meek <keemllib@…>]

If memory serves, the reason I wrote the ticket was that someone on -users (list or channel) was using --nologserver and wasn't getting one of the other forms of logging. [Which they shouldn't expect because logging only goes to the console.]

I haven't seen any reports of users not getting logs since then. I would suggest the fix is valid based on the commit cited on the 1st line of the initial description (changeset:f124159.)

[Bill Meek <keemllib@…>]

For additional history regarding the initial revert, please see the logs at 13:11:44 here:

irc.mythtv.org/ircLog/channel/4/2014-11-19

[Karl Egly]

Convenience link to the chat log: ​http://irc.mythtv.org/ircLog/channel/4/2014-11-19:12:49:52/2014-11-19:13:13:44

Jya, can you clarify the intention of --nologserver? Your comment when reopening and your documentation of the option in the source code say different things. I'm tempted to let the documentation describe the implementation as it is now. Although I'm not sure how the implementation is now :)

​https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythbase/mythcommandlineparser.cpp#L2436

add("--nologserver", "nologserver", false, "Disable all logging but console.", "")
            ->SetGroup("Logging");

[Bill Meek <keemllib@…>]

Suggest a 0.28 milestone because implementing it now could prevent 0.27 user's backends from starting (if they have incorrect flags.)

I'll add it to the 0.28 release notes if fixed.

[JYA]

Replying to dekarl:

Convenience link to the chat log: ​http://irc.mythtv.org/ircLog/channel/4/2014-11-19:12:49:52/2014-11-19:13:13:44

Jya, can you clarify the intention of --nologserver? Your comment when reopening and your documentation of the option in the source code say different things. I'm tempted to let the documentation describe the implementation as it is now. Although I'm not sure how the implementation is now :)

did I add that option?

maybe easiest would be to rename that argument, because right now it's super confusing.

[Bill Meek <bmeek@…>]

In ac415356601a0122b2c0c6cd6df0f265a8afe744/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available