AutoExpire method defaults to no-auto-expire; no GUI to set "oldest-first" policy

[Robert Tsai <rtsai1111>]

In AutoExpire::FillExpireList, the expMethod is chosen by querying for the value of "AutoExpireMethod", and defaulting to zero.

The "1" method is the "oldest-first" auto-expire method. So the default ("0") is to not auto-expire anything at all (as confirmed by the comment).

However, the GUI for configuring AutoExpire (e.g., a combo box with only one choice) has been under #if 0 for quite some time now. So any fresh install will not have any way to turn on auto-expire short of entering MySQL and inserting the configuration value by hand.

I think at least for now, AutoExpire::FillExpireList should use a default value of "1".

Another possibility is to rework the AutoExpire configuration UI to use a single combo box for:

AutoExpire: Off (0)

Oldest-First (1)

instead of the current boolean AutoExpire on/off followed by a (commented-out) "autoexpire method". But I'm not sure if that will also affect max-episodes auto-expire.

[danielk]

I'll look at this. I probably broke it.

[danielk]

(In [6850]) This should fix #120.

I've removed the AutoExpireEnabled setting stuff and just use the AutoExpireMethod setting, defaulting to the "Oldest Show First" method.

If you installed MythTV in the last month or so you may need to enter the Setup:TV Settings:General pane and change the "Auto Expire Method:" from "None" to "Oldest Show First".

Also, if you wish auto expire to be disabled (bad idea btw), then you will want to change the setting to "None".