Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#12144 closed Patch - Feature (fixed)

Save volume only on TV Player exit (optimize DB usage)

Reported by: angela.schmid@… Owned by: Roger Siddons
Priority: minor Milestone: 0.28
Component: MythTV - Audio Output Version: 0.27-fixes
Severity: low Keywords: mysql volume save
Cc: Ticket locked: no

Description

Saving the volume to the DB on each volume change is unnecessary. To optimize DB usage, the patch saves the volume only on exit of the TV Player (TV::PrepareToExitPlayer).

There was also a small bug: On each volume change in the TV Player the volume is saved twice when software volume is configured:

In libs/libmyth/audio/volumebase.cpp VolumeBase::SetCurrentVolume

Attachments (1)

0001-Save-volume-only-on-TV-Player-exit.patch​ (4.3 KB ) - added by angela.schmid@… 11 years ago.

Download all attachments as: .zip

Change History (7)

by angela.schmid@…, 11 years ago

Attachment: 0001-Save-volume-only-on-TV-Player-exit.patch​ added

comment:1 by Jean-Yves Avenard <jyavenard@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 85baf66840dbf728af732f1d346ffe63fbe3ab41/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:2 by JYA, 11 years ago

Milestone: unknown → 0.28

comment:3 by Roger Siddons <rsiddons@…>, 10 years ago

In 26e44bf08cf2f3b17a3eae7efa8afa65156d7fe0/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:4 by Roger Siddons <rsiddons@…>, 10 years ago

In 874b65bc84bd080ec538d27a12573b2e582ffaef/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:5 by Lawrence Rust <lvr@…>, 10 years ago

In abaf8ddb8ca4f9cc1196a08ca9593498398f948f/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:6 by Roger Siddons, 10 years ago

Owner: changed from JYA to Roger Siddons
Note: See TracTickets for help on using tickets.