Opened 20 years ago
Closed 20 years ago
#1293 closed patch (fixed)
Need to check if both seriesid and programid exists
| Reported by: | Oscar Carlsson | Owned by: | xris |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.20 |
| Component: | mythweb | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
For "This show was recorded", both seriesid and programid need to exist in order to be able to use it for the check.
Attachments (1)
Change History (9)
comment:1 by , 20 years ago
comment:2 by , 20 years ago
| Type: | defect → patch |
|---|
I think the current SVN checks for programid/seriesid. Looking at ProgramInfo::ForgetHistory, I think that oldrecorded.duplicate might need to be checked as well. See patch. This also has the (positive?) side-effect that non-AutoExpired recordings are no longer marked as "This showing was recorded".
by , 20 years ago
| Attachment: | mythweb.oldrecorded.diff added |
|---|
comment:3 by , 20 years ago
Hi Robert,
I tried the patch, but am still getting shows in the future displaying as "Already recorded"
Do you need anything from me? screenshots/db rows?
Cheers Dave
comment:4 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 20 years ago
Yep, I was just about to post this myself :) looks like the OR should have been an AND :)
can we push this change the 0.19-fixes please :)
comment:6 by , 20 years ago
Next problem with this is the title/subtitle/description comparation that breaks if for example there are no subtitles. "" = "" evaluates as true thus marking the show as previously recorded..
It needs to behave the same way as myth does, if there's no sub AND desc, it can't match them.
comment:7 by , 20 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Since this bug only cropped up in the weeks before .19 was released, shouldn't it be part of the .19 fixes?
see #1334 for my version of the problem.