Opened 8 years ago
Closed 7 years ago
#13381 closed Bug Report - General (fixed)
"Setting NIT-ID" message shows unsigned int
| Reported by: | Klaas de Waal | Owned by: | Klaas de Waal |
|---|---|---|---|
| Priority: | trivial | Milestone: | 30.1 |
| Component: | MythTV - Channel Scanner | Version: | Master Head |
| Severity: | low | Keywords: | NIT-ID DVB-T channelscan |
| Cc: | Stuart Auchterlonie | Ticket locked: | no |
Description
My mythtv-setup gives the following message on a DVB-T scan:
I ChannelScanSM(/dev/dvb/adapter1/frontend0): Setting NIT-ID to 4294967295
This is obviously not correct and it happens when the "Network ID" of a video source is left at its default value of -1.
The value is printed as an unsigned int in channelscan_sm.cpp in lines 193-198:
{
uint nitid = query.value(0).toInt();
data->SetRealNetworkID(nitid);
LOG(VB_CHANSCAN, LOG_INFO, LOC +
QString("Setting NIT-ID to %1").arg(nitid));
}
The value should be printed as an integer as it is really an integer where it is used, as shown in dvbstreamdata.h:
// Real network ID for broken providers
int _dvb_real_network_id;
inline void DVBStreamData::SetRealNetworkID(int real_network_id)
{
QMutexLocker locker(&_listener_lock);
_dvb_real_network_id = real_network_id;
}
The (trivial) patch to change "uint nitid" to "int nitid" is attached.
Attachments (1)
Change History (4)
by , 8 years ago
| Attachment: | 20190119-nitid-int.patch added |
|---|
comment:1 by , 8 years ago
| Milestone: | needs_triage → 30.1 |
|---|---|
| Owner: | set to |
| Status: | new → accepted |
comment:2 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | accepted → assigned |
comment:3 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.

In 24650f405/mythtv: