Patches to fix php count warnings with PHP 7.2

[daraden]

These patches are to resolve count() warnings when using PHP 7.2. Changes just check if the object is not null before calling the count function, otherwise the count variable is set to 0.

link to PHP manual noting the count() behavior as an incompatible change in PHP 7.2​https://secure.php.net/manual/en/migration72.incompatible.php

[daraden]

mythtv php bindings count patch

[Peter Bennett]

See also #13324, #13290

[Stuart Auchterlonie]

Needs backporting to fixes/29 and fixes/30

[hobbes1069]

Don't know if it's the right way but I "fixed" this on Fedora using the following:

iff --git a/modules/tv/tmpl/default/detail.php b/modules/tv/tmpl/default/detail.php
index f6d1faa9..4975f415 100644
--- a/modules/tv/tmpl/default/detail.php
+++ b/modules/tv/tmpl/default/detail.php
@@ -842,7 +842,7 @@
             }
             echo '            </ul>';
         }
-        if (count($program->jobs['queue'])) {
+        if (is_array($program->jobs['queue']) && count($program->jobs['queue'])) {
             echo t('Queued jobs'), ':',
                  '            <ul class="-queued">';
             foreach ($program->jobs['queue'] as $job) {
@@ -856,7 +856,7 @@
             }
             echo '            </ul>';
         }
-        if (count($program->jobs['done'])) {
+        if (is_array($program->jobs['done']) && count($program->jobs['done'])) {
             echo t('Recently completed jobs'), ':',
                  '            <ul class="-done">';
             foreach ($program->jobs['done'] as $job) {

[hobbes1069]

Would it be safe to apply the two patches to v30? I would like to fix this for Fedora / RPM Fusion.

[daraden]

fixed typo in mythwebcount.patch

[daraden]

Should work fine with v30(patches are working on my 29 backend). files the patches modify are listed as last modified 2 or more years ago.

[jr3us]

Per the following thread in the forum ( ​https://forum.mythtv.org/viewtopic.php?p=13823#p13823 ) the count error also affects the file Mythbackend.php as follows:

Warning at /usr/share/mythtv/bindings/php/MythBackend.php, line 194: NoTrans: count(): Parameter must be an array or an object that implements Countable!!

[Richard Shaw <hobbes1069@…>]

In c04a650ee/mythweb:

Error: Processor CommitTicketReference failed

GIT backend not available

[David Hampton <mythtv@…>]

In 7e2e51d1d/mythweb:

Error: Processor CommitTicketReference failed

GIT backend not available

[David Hampton <mythtv@…>]

In dc87fada5/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available

[David Hampton <mythtv@…>]

In 7a8752dc0f/mythtv:

Error: Processor CommitTicketReference failed

GIT backend not available