Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13632 closed Patch - Feature (fixed)

Resolve TODO in metadatagrabber

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: 32.0
Component: MythTV - Mythmetadatalookup Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Resolve TODO in metadatagrabber

In metadatagrabber.cpp there is a comment: 

// TODO
// it would be nice to statically compile these, but I can't manage to get it
// to compile.  apparently initializer lists are supported in QT5/CPP11 that
// will make this work.  for now, use a lock and initialize on first access.

In Qt 5.2 (ish?) Qt added C++11 initializer lists for QMap.

Since recent fixes and master both require both more recent Qt and C++ versions, let us eliminate a legacy TODO.

Lightly tested in a development test environment

Attachments (1)

0001-Resolve-TODO-in-metadatagrabber-to-initialize-static.patch​ (4.2 KB ) - added by Gary Buhrmaster 5 years ago.
Resolve TODO in metadatagrabber

Download all attachments as: .zip

Change History (7)

by Gary Buhrmaster, 5 years ago

Attachment: 0001-Resolve-TODO-in-metadatagrabber-to-initialize-static.patch​ added

Resolve TODO in metadatagrabber

comment:1 by David Hampton, 5 years ago

Owner: set to David Hampton
Status: new → assigned

comment:2 by Stuart Auchterlonie, 5 years ago

Milestone: needs_triage → 32.0

comment:3 by Gary Buhrmaster <gary.buhrmaster@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In d8e6d23077/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:4 by Gary Buhrmaster <gary.buhrmaster@…>, 5 years ago

In 6e61aa988/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:5 by Gary Buhrmaster <gary.buhrmaster@…>, 5 years ago

In d8e6d23077/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:6 by Gary Buhrmaster <gary.buhrmaster@…>, 5 years ago

In 6e61aa988/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available
Note: See TracTickets for help on using tickets.