Opened 20 years ago
Closed 20 years ago
#1420 closed enhancement (fixed)
speed-up DVB event parsing with caching of QTextCodecs
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.20 |
| Component: | dvb | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I profiled mythtv today and found a bottle neck in the DVB event parsing.
Without the patch dvb_decode_text() takes about 93% of SIParser::ParseTable. The patch drops this to 4%.
I'm not sure if the caching in a static patch is acceptable (in particular if it's threadsafe). But it is working fine for me.
refs #892
Attachments (2)
Change History (6)
comment:1 by , 20 years ago
| Type: | defect → enhancement |
|---|
by , 20 years ago
| Attachment: | mythtv_codec_chaching.patch added |
|---|
by , 20 years ago
| Attachment: | mythtv_codec_chaching2.patch added |
|---|
comment:2 by , 20 years ago
| Milestone: | → 0.20 |
|---|---|
| Version: | → head |
The statics probably won't work, but I'll make sure some caching of these is implemented in #1035.
comment:3 by , 20 years ago
They actually work on a dual DVB backend. Valgrind doesn't complain.
But a different solution is fine by my.
Note:
See TracTickets
for help on using tickets.
updated patch, removed tabs and added check for array access, as suggested by ijr