Opened 21 years ago

Closed 21 years ago

#167 closed patch (fixed)

New mtd ISO feature deletes ripfile twice

Reported by: Anduin Withers <awithers@…> Owned by: jdonavan
Priority: minor Milestone: unknown
Component: mythdvd Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Bug fix:

ripfile is being deleted and not set to NULL, patch never deletes (like DVDThread).

Debug:

Some debug code in there, as ripping a full DVD takes way too long to catch a cleanup bug.

Cleanup:

Moved buffer from heap to stack.

Attachments (2)

mtdiso.patch​ (1.6 KB ) - added by Anduin Withers <awithers@…> 21 years ago.
mtdcb.patch​ (5.5 KB ) - added by Anduin Withers <awithers@…> 21 years ago.
ripfile again, also mt issues

Download all attachments as: .zip

Change History (7)

by Anduin Withers <awithers@…>, 21 years ago

Attachment: mtdiso.patch​ added

comment:1 by jdonavan, 21 years ago

Owner: changed from Isaac Richards to jdonavan

comment:2 by jdonavan, 21 years ago

Resolution: → fixed
Status: new → closed

(In [6949]) Chnage the buffer for ISO rips to not be dynamicly allocated. Based off of the patch submitted on #167. This should fix the problems with mtd crashing now and then after an iso rip.

This closes #167.

comment:3 by Anduin Withers <awithers@…>, 21 years ago

Resolution: fixed
Status: closed → reopened

Actual fix not applied.

by Anduin Withers <awithers@…>, 21 years ago

Attachment: mtdcb.patch​ added

ripfile again, also mt issues

comment:4 by Anduin Withers <awithers@…>, 21 years ago

New patch includes that which was excluded from the last commit (namely the fix). Also fixes some QString + thread issues that were causing an occasional crash when the planets were aligned just right (which seems to happen more than you'd hope). Hopefully fixes more than it breaks.

comment:5 by jdonavan, 21 years ago

Resolution: → fixed
Status: reopened → closed

(In [6998]) Close #167 by applying the patch contained in it.

Note: See TracTickets for help on using tickets.