Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#1821 closed patch (fixed)

Reorganisation of ClassicCommDetector's logo detection and scene change detection

Reported by: lucas@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: mythcommflag
Cc: Ticket locked: no

Description

this patch seperates the logo detection from ClassicCommDetector, and puts it in its own class. I've done the same for the scene change detection, I'll open a seperate ticket with a seperate patch later on for that.

The new class, ClassicLogoDetector, is currently still pretty intertwined with the ClassicCommDetector. ClassicCommDetector is putting pretty strong limitations on the implementation of a logodetector class, as in the current setup it gets one shot to search for a logo, and later on has to tell us if that logo is currently present in a frame.. A logodetector has no freedom such that it might realize at the end of a recording that another logo is present, and that it would like to do another pass at the entire recording to look for this new logo again.. anyway, stuff like that are likely future improvements.. first things first.

This patch mantains functional equivalence to svn head. I've compared behaviour of snv head, and this patch on two recordings, and they had not only identical results, but identical verbose debug output.

Attachments (2)

logodetectorpatch​ (44.1 KB ) - added by lucas@… 20 years ago.
the patch
combinedpatch.bz2​ (9.0 KB ) - added by lucas@… 20 years ago.
combined patch of logodetector extraction, and scene detector extraction.

Download all attachments as: .zip

Change History (5)

by lucas@…, 20 years ago

Attachment: logodetectorpatch​ added

the patch

by lucas@…, 20 years ago

Attachment: combinedpatch.bz2​ added

combined patch of logodetector extraction, and scene detector extraction.

comment:1 by lucas@…, 20 years ago

Summary: Reorganisation of ClassicCommDetector's logo detection. → Reorganisation of ClassicCommDetector's logo detection and scene change detection

added a new patch that has both the logo detection extracted from ClassicCommDetector, and put into its own class, and the scene change detection extracted from ClassicCommDetector, and put into its own class. I had a bit of a hard time making two seperate patches (didn't apply cleanly after eachother), so I've made a combined one. If this makes it too hard to review let me know and I'll try to seperate them.

comment:2 by cpinkham, 20 years ago

Resolution: → fixed
Status: new → closed

(In [10547]) Separate out the 'classic' logo detector and scene change detector code into separate classes. There should be no functionality change, the flagger code still should produce the same exact commecial skip list as before for the same recording.

Closes #1821. Patch by Lucas Meijer.

comment:3 by cpinkham, 20 years ago

(In [10547]) Separate out the 'classic' logo detector and scene change detector code into separate classes. There should be no functionality change, the flagger code still should produce the same exact commecial skip list as before for the same recording.

Closes #1821. Patch by Lucas Meijer.

Note: See TracTickets for help on using tickets.