Opened 19 years ago
Closed 19 years ago
#1897 closed patch (wontfix)
PiP size
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
PiP sizing has been broken for me for some time. I've tested the attached patch with a variety of sources (SD/HD, 4:3/16:19/Anamorphic16:9), display settings (1080i/720p/Anamorphic576i/1024x768 etc) and letterboxing. Hopefully I haven't missed anything...
Logically we can igore non-square pixels in the display as this will be accounted for when the main video frame is scaled/displayed. Likewise, non-square pixels in the video will be adjusted for by the Pip scaler. We only really need to adjust for letterboxing and the relative aspect ratios of the pip and main video.
I'm fixing this as part of #843, this code will be removed in the new PiP code.