Opened 19 years ago

Closed 19 years ago

#2156 closed patch (fixed)

detection for DVD backups on HD for internal player (make it more usable as the overall MythVideo player)

Reported by: Pekka Jääskeläinen <pekka.jaaskelainen@…> Owned by: Anduin Withers
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This trivial patch adds support for using the Internal video player for playing DVD backups stored on HD. The patch works simply by detecting a path which is a directory containing a VIDEO_TS subdirectory or a filename with .img or .iso extension to be a DVD backup, and prepends "dvd:" in front of the pathname.

Attachments (3)

internal_dvd_player_dvdbackup_playback_improvements.diff​ (808 bytes ) - added by Pekka Jääskeläinen <pekka.jaaskelainen@…> 19 years ago.
Against trunk
updated.patch​ (945 bytes ) - added by skamithi 19 years ago.
updated2.patch​ (1006 bytes ) - added by skamithi 19 years ago.
add .img to the list of recognized dvd images. so far only .iso ext is recognized as a dvd image.

Download all attachments as: .zip

Change History (11)

by Pekka Jääskeläinen <pekka.jaaskelainen@…>, 19 years ago

Attachment: internal_dvd_player_dvdbackup_playback_improvements.diff​ added

Against trunk

comment:1 by anonymous, 19 years ago

Owner: changed from danielk to skamithi

comment:2 by Isaac Richards, 19 years ago

Resolution: → wontfix
Status: new → closed

I don't think this sort of logic should go into RingBuffer class, please move it higher up.

comment:3 by skamithi, 19 years ago

i agree. just wrote an updated patch. is this one okay ?

by skamithi, 19 years ago

Attachment: updated.patch​ added

comment:4 by skamithi, 19 years ago

Resolution: wontfix
Status: closed → reopened

comment:5 by Isaac Richards, 19 years ago

Yup, much better, thanks.

comment:6 by skamithi, 19 years ago

Milestone: → 0.20
Version: → head

by skamithi, 19 years ago

Attachment: updated2.patch​ added

add .img to the list of recognized dvd images. so far only .iso ext is recognized as a dvd image.

comment:7 by skamithi, 19 years ago

Owner: changed from skamithi to Anduin Withers
Status: reopened → new

comment:8 by Anduin Withers, 19 years ago

Resolution: → fixed
Status: new → closed

(In [10766]) Adds support for playing .img files and directories containing a VIDEO_TS directory.

Closes #2156

Note: See TracTickets for help on using tickets.