Opened 19 years ago
Closed 18 years ago
#2163 closed patch (fixed)
incorrect placement of edit marks
| Reported by: | Owned by: | Janne Grunau | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythtv | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | yes |
Description
Edit marks with enabled overscan are incorrect placed since the OSDSet constructor has no knowledge of [xy]offset. They are correct after a OSD reinit. Atteched patch changes the constructor and and uses the new constructor in ShowEditArrow.
The edit arraws image is not correctly scaled to PAL resulotion. After a Reinit() it is scaled. The Patch calls Reinit after creating a new edit arrow since I couldn't figure out where the image is scaled. I hope someone with more knowledge of the osd code can take a look at this issue and solve it correctly.
Attachments (3)
Change History (10)
comment:1 by , 19 years ago
by , 19 years ago
| Attachment: | 2163_fix_edit_osd_placement.diff added |
|---|
libmythtv patch for correct osd placement of cut marks
comment:2 by , 19 years ago
Updated patch against libmythtv.
-fixed inconsistent rounding.
-displays the cut marks images centered at the computed position since some themes use shadows.
The themes handle the edit osd inconsistantly (I suspect each the developer worked around the bugs until it was correctly displayed).
Updated theme images and a patch for the osd.xmls attached
comment:4 by , 19 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [12492]) Fixes #2163, corrects edit arrows placement in all themes
Adds (x|y)offset to OSDSet constructor (needed for overscan) Scales edit arrows images accordingly to the screen resolution since some edit arrows use shadows the center of the cut image lies at the cut point changed all cut images and osd.xml in all themes
comment:5 by , 19 years ago
| Milestone: | → 0.21 |
|---|
comment:6 by , 18 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Please apply changeset #12492 to the 0.20.2 branch.
comment:7 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
| Ticket locked: | set |
Edit marks are still displayed off with defaultosd and blueosd. Il update the patch.