Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#2216 closed defect (fixed)

Bug in bswap_dbl() corrupts data causing incorrect fps and aspect ratio fields in NUV header.

Reported by: zdevito@… Owned by: Nigel
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords: bswap endian double
Cc: Ticket locked: no

Description

bswap_dbl() tries to swap two variables without saving one to a temporary variable, corrupting the value of the swapped double. This bug only occurs on big endian backends that need to use bswap_dbl. This bug causes several side effects: playback of the video works correctly but often emits lots of "NVP: Prebuffer wait timed out 10 times." messages, OSD messages will not fade away automatically, and nuvexport cannot export the files. I have attached a patch that fixes this bug.

Attachments (1)

bwap_dbl_fix.diff.txt​ (531 bytes ) - added by zdevito@… 20 years ago.
fixes a bug in bswap_dbl

Download all attachments as: .zip

Change History (5)

by zdevito@…, 20 years ago

Attachment: bwap_dbl_fix.diff.txt​ added

fixes a bug in bswap_dbl

comment:1 by Isaac Richards, 20 years ago

Owner: changed from Isaac Richards to Nigel

comment:2 by Nigel, 20 years ago

Milestone: → 0.20
Status: new → assigned
Version: → head

Hmmm. One of the oldest programming mistakes in the book. Where the heck did I copy/paste that code from?

comment:3 by Nigel, 20 years ago

Resolution: → fixed
Status: assigned → closed

(In [10903]) Closes #2216

comment:4 by Nigel, 20 years ago

(In [10905]) I can't even apply a patch properly these days. This really closes #2216

Note: See TracTickets for help on using tickets.