Teletext window not centered in various zoom modes

[anonymous]

watching teletext on my PVR350 card is not okay in "4:3 Zoom", "16:9 Zoom" and "16:9 Zoom strechted" modes. the teletext window is not centered (and therefore cut off).

[barnasc]

Problem confirmed. I will look into this to create a patch.

[barnasc]

2597-v1.patch now applies the screen offsets (xoff and yoff) correctly to display teletext pages in all screen modes.

[danielk]

barnasc, I don't think this patch is correct.

Shouldn't you just be able to call OSD::Reinit() with the new visibleBounds when in a zoom mode (when using a software composited OSD, you should not do this when using a ChromaKey or OpenGL OSD).

-- Daniel

[barnasc]

Just reviewed the OSDTypeCC classes. In here, the initialization and Reinit() functions store the display offsets in local member class variables which are used for the different drawing routines. Is this what you prefer?

Martin

[barnasc]

Got it. In the OSDType708CC class, CalcBounds() measures the window size and this is applied in the original Draw() routine without parsing xoff and yoff. Instead, it calls the other Draw() function using the upper left corner information. Will see how I can apply this on the Teletext stuff.

For some reason, the older OSD classes do not have a CalcBounds() but still use xoff, yoff. What is the reason of this?

Martin

[danielk]

Yep, just use OSDType708CC as a guide. The older classes don't use CalcBounds() because they were written before it was and haven't been ported yet. E-mail me with any additional questions.

Reopen the ticket when you have a new patch ready for review.