storage groups / preview pixmap generate problems

[jwestfall]

Hi

Since upgrading to post storage groups code I have been unable to generate pixmaps, my only backend cant figure out the .mpg file needed by the pixmap generator are local.

2006-12-03 15:12:35.130 SG(Default): FindRecordingFile: Searching for '1060_20061106230000.mpg'
2006-12-03 15:12:35.130 SG(Default): FindRecordingDir: Checking '/tv/mythtv'
2006-12-03 15:12:35.131 SG(Default): FindRecordingFile: Found '/tv/mythtv/1060_20061106230000.mpg'
2006-12-03 15:12:35.131 ProgramInfo: GetPlaybackURL: File is local: '/tv/mythtv/1060_20061106230000.mpg'
2006-12-03 15:12:35.131 Local file path: /tv/mythtv/1060_20061106230000.mpg
2006-12-03 15:12:35.139 MainServer::HandleAnnounce Monitor
2006-12-03 15:12:35.139 adding: imini as a client (events: 0)
2006-12-03 15:12:35.140 RemoteFile::openSocket(control socket):
                        Could not connect to server "" @ port -1
2006-12-03 15:12:35.140 RemoteFile::openSocket(file data socket):
                        Could not connect to server "" @ port -1
2006-12-03 15:12:35.141 RingBuffer::RingBuffer(): Failed to open remote file (1060_20061106230000.mpg)
2006-12-03 15:12:35.141 Preview Error: Previewer could not open file: '1060_20061106230000.mpg'
2006-12-03 15:12:35.141 MainServer: Failed to make preview image.

I havent had time to fully read up on the storage groups changes, but the attach patch fixes the issue for me.

thx jim

[cpinkham]

(In [12185]) Fix creation of preview pixmaps generated by MainServer::HandleGenPreviewPixmap as well as honoring masterBackendOverride.

Closes #2774.

[cpinkham]

(In [12188]) Fix a bug that was introduced in the Storage Groups patch in the Ringbuffer is_local determination code. We need to assume a file is local if it starts with a '/', not just if we can find it local using QFile::exists().

Also, as a safety precaution in ProgramInfo::GetPlaybackURL, if the file should be local (ie, we're on the backend that recorded the file), but we can't find it, return a filename instead of returning a myth:// URL. If we return a myth:// URL, the caller could try to stream a file that doesn't exist on the backend.

References #2774.